Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2469803002: Only send distillability message on valid pipe (Closed)

Created:
4 years, 1 month ago by mdjones
Modified:
3 years, 11 months ago
Reviewers:
wychen
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only send distillability message on valid pipe For the remaining cases where the renderer tries to connect to a nonexistent DistillabilityService, make sure the connection was successful before sending a message. BUG=661417 Review-Url: https://codereview.chromium.org/2469803002 Cr-Commit-Position: refs/heads/master@{#441700} Committed: https://chromium.googlesource.com/chromium/src/+/98a412efa58cb8aa48d70b473c38bce2cd6391ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/dom_distiller/content/renderer/distillability_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mdjones
ptal
3 years, 11 months ago (2017-01-04 18:58:06 UTC) #3
wychen
lgtm
3 years, 11 months ago (2017-01-05 02:09:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469803002/1
3 years, 11 months ago (2017-01-05 16:48:29 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:01:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98a412efa58cb8aa48d70b473c38...

Powered by Google App Engine
This is Rietveld 408576698