Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2469713002: Remove an unused file defining WebSocket multiplexing related constants (Closed)

Created:
4 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 1 month ago
Reviewers:
yhirano, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unused file defining WebSocket multiplexing related constants R=yhirano@chromium.org,mmenke@chromium.org BUG=none Committed: https://crrev.com/903c8cd71b7ec47ce130797fede9927e5e972ed5 Cr-Commit-Position: refs/heads/master@{#430241}

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M net/net.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/websockets/websocket_channel.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/websockets/websocket_channel_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
D net/websockets/websocket_mux.h View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
tyoshino (SeeGerritForStatus)
4 years, 1 month ago (2016-11-02 05:25:19 UTC) #11
yhirano
lgtm
4 years, 1 month ago (2016-11-02 05:28:59 UTC) #12
tyoshino (SeeGerritForStatus)
+mmenke for net.gypi
4 years, 1 month ago (2016-11-02 06:56:53 UTC) #14
mmenke
On 2016/11/02 06:56:53, tyoshino wrote: > +mmenke for net.gypi LGTM. If you want, I'm happy ...
4 years, 1 month ago (2016-11-02 12:42:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469713002/20001
4 years, 1 month ago (2016-11-07 08:22:45 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 09:23:30 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/903c8cd71b7ec47ce130797fede9927e5e972ed5 Cr-Commit-Position: refs/heads/master@{#430241}
4 years, 1 month ago (2016-11-07 09:26:18 UTC) #22
tyoshino (SeeGerritForStatus)
4 years, 1 month ago (2016-11-08 06:18:52 UTC) #23
Message was sent while issue was closed.
On 2016/11/02 12:42:22, mmenke wrote:
> On 2016/11/02 06:56:53, tyoshino wrote:
> > +mmenke for net.gypi
> 
> LGTM.  If you want, I'm happy to sign off on a modification to net/OWNERs
making
> websocket owners also owners of the net BUILD.gn and net.gypi files.  Also
> completely happy to approve one-off CLs like this, just thinking it might make
> your lives easier.

Thank you. Created a CL.
https://codereview.chromium.org/2488593002
We'll make sure to just get your review whenever needed.

Powered by Google App Engine
This is Rietveld 408576698