Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2488593002: Add per-file lines to net/OWNERS to allow net/websockets/OWNERS to change BUILD.gn (Closed)

Created:
4 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 1 month ago
Reviewers:
mmenke, yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add per-file lines to net/OWNERS to allow net/websockets/OWNERS to change BUILD.gn R=mmenke@chromium.org BUG=none Committed: https://crrev.com/14c5dc20bf2eeb7848a867e6b97b6dbe2e8fa5e9 Cr-Commit-Position: refs/heads/master@{#430836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tyoshino (SeeGerritForStatus)
4 years, 1 month ago (2016-11-08 06:19:08 UTC) #3
mmenke
LGTM
4 years, 1 month ago (2016-11-08 11:36:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488593002/1
4 years, 1 month ago (2016-11-09 01:37:24 UTC) #7
yhirano
lgtm
4 years, 1 month ago (2016-11-09 01:37:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 02:34:35 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 02:39:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14c5dc20bf2eeb7848a867e6b97b6dbe2e8fa5e9
Cr-Commit-Position: refs/heads/master@{#430836}

Powered by Google App Engine
This is Rietveld 408576698