Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2469553002: Use a custom exception to signal failure to reproduce (Low confidence). (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
dtu, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Use a custom exception to signal failure to reproduce (Low confidence). By using this exception we use the same codepath than the case where the failure occurs upon finding adjacent revisions inside the reference range. R=dtu@chromium.org,prasadv@chromium.org BUG=659407 Committed: https://chromium.googlesource.com/chromium/tools/build/+/106b0ae9202f77f7066a8f06efe8d7f7a9b0ae29

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 1 month ago (2016-10-31 21:55:12 UTC) #1
dtu
lgtm
4 years, 1 month ago (2016-11-01 01:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469553002/1
4 years, 1 month ago (2016-11-01 18:26:59 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:37:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/106b0ae9202f77f7066a...

Powered by Google App Engine
This is Rietveld 408576698