Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json

Issue 2469553002: Use a custom exception to signal failure to reproduce (Low confidence). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
index a06f56de02d2ae55c4ba0f8b633e4f9d369b6e91..d2fa7f21f02f2e7a6d52485034f1c970e2cdb4b6 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
@@ -1841,7 +1841,7 @@
"@@@STEP_LOG_LINE@json.output@ ]@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@",
- "@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_LO_INIT_CONF\"]@@@"
+ "@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_LO_INIT_CONF\", \"B4T_REF_RANGE_FAIL\"]@@@"
]
},
{
@@ -1910,24 +1910,7 @@
],
"cwd": "[SLAVE_BUILD]",
"name": "Post bisect results",
- "stdin": "{\"data\": {\"aborted_reason\": \"The metric values for the initial \\\"good\\\" and \\\"bad\\\" revisions do not represent a clear regression.\", \"bad_revision\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"bisect_bot\": \"winx64_perf_tester\", \"bug_id\": \"-1\", \"buildbot_log_url\": \"http://build.chromium.org/p/chromium/builders/winx64_zen_perf_bisect/builds/571\", \"change\": null, \"command\": \"src/tools/perf/run_benchmark -v --browser=release --output-format=valueset smoothness.tough_scrolling_cases\", \"culprit_data\": null, \"good_revision\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"revision_data\": [{\"commit_hash\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"good\", \"revision_string\": \"chromium@a6298e4afe\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}, {\"commit_hash\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"bad\", \"revision_string\": \"chromium@00316c9ddf\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}], \"status\": \"completed\", \"test_type\": \"perf\", \"try_job_id\": null, \"warnings\": [\"Bisect failed to reproduce the regression with enough confidence.\"]}, \"url\": \"https://chromeperf.appspot.com/post_bisect_results\"}",
- "stdout": "/path/to/tmp/json",
- "~followup_annotations": [
- "@@@STEP_TEXT@Failed to upload result to Perf Dashboard. Error response: None@@@",
- "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
- "@@@STEP_LOG_END@json.output (invalid)@@@",
- "@@@STEP_FAILURE@@@"
- ]
- },
- {
- "cmd": [
- "python",
- "-u",
- "RECIPE_MODULE[build::perf_dashboard]\\resources\\post_json.py"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "Post bisect results (2)",
- "stdin": "{\"data\": {\"aborted_reason\": \"The metric values for the initial \\\"good\\\" and \\\"bad\\\" revisions do not represent a clear regression.\", \"bad_revision\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"bisect_bot\": \"winx64_perf_tester\", \"bug_id\": \"-1\", \"buildbot_log_url\": \"http://build.chromium.org/p/chromium/builders/winx64_zen_perf_bisect/builds/571\", \"change\": null, \"command\": \"src/tools/perf/run_benchmark -v --browser=release --output-format=valueset smoothness.tough_scrolling_cases\", \"culprit_data\": null, \"good_revision\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"revision_data\": [{\"commit_hash\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"good\", \"revision_string\": \"chromium@a6298e4afe\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}, {\"commit_hash\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"bad\", \"revision_string\": \"chromium@00316c9ddf\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}], \"status\": \"completed\", \"test_type\": \"perf\", \"try_job_id\": null, \"warnings\": [\"Bisect failed to reproduce the regression with enough confidence.\"]}, \"url\": \"https://chromeperf.appspot.com/post_bisect_results\"}",
+ "stdin": "{\"data\": {\"aborted_reason\": \"The metric values for the initial \\\"good\\\" and \\\"bad\\\" revisions do not represent a clear regression.\", \"bad_revision\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"bisect_bot\": \"winx64_perf_tester\", \"bug_id\": \"-1\", \"buildbot_log_url\": \"http://build.chromium.org/p/chromium/builders/winx64_zen_perf_bisect/builds/571\", \"change\": null, \"command\": \"src/tools/perf/run_benchmark -v --browser=release --output-format=valueset smoothness.tough_scrolling_cases\", \"culprit_data\": null, \"good_revision\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"revision_data\": [{\"commit_hash\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"good\", \"revision_string\": \"chromium@a6298e4afe\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}, {\"commit_hash\": \"00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111\", \"depot_name\": \"chromium\", \"mean_value\": 21.0, \"result\": \"bad\", \"revision_string\": \"chromium@00316c9ddf\", \"std_dev\": 3.1622776601683795, \"values\": [19, 20, 21, 22, 23]}], \"status\": \"failed\", \"test_type\": \"perf\", \"try_job_id\": null, \"warnings\": []}, \"url\": \"https://chromeperf.appspot.com/post_bisect_results\"}",
"stdout": "/path/to/tmp/json",
"~followup_annotations": [
"@@@STEP_TEXT@Failed to upload result to Perf Dashboard. Error response: None@@@",
@@ -1938,7 +1921,7 @@
},
{
"name": "$result",
- "reason": "Failed to upload result to Perf Dashboard. Error response: None",
+ "reason": "Bisect cannot identify a culprit: Bisect failed to reproduce the regression with enough confidence.",
"recipe_result": null,
"status_code": 1
}

Powered by Google App Engine
This is Rietveld 408576698