Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2469503002: Setting a maximum number of test runs per revision. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Setting a maximum number of test runs per revision. The chosen value is 20 runs per revision. The reasoning is that 20 is a round number that should produce no less than 18 values (one per run, in a test that is at most 10% flaky) which has in the past seemed sufficient to decide that the values are unlikely to converge per MWU. Also, adding test coverage and fixing a small bug highlighted by this change. (See bisector.py one line change) R=dtu@chromium.org BUG=659906 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d8aa54bdb96167b4fd89ad1c5627fecadd18b21c

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 1 month ago (2016-10-31 20:22:25 UTC) #1
dtu
lgtm
4 years, 1 month ago (2016-10-31 20:26:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469503002/1
4 years, 1 month ago (2016-10-31 20:27:50 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:39:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d8aa54bdb96167b4fd89...

Powered by Google App Engine
This is Rietveld 408576698