Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/test_api.py

Issue 2469503002: Setting a maximum number of test runs per revision. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py b/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
index 034a769175ac8fe4f6ec0a2230a4aca5b90fc241..278f8acd2041b0417abe0e4a95e6c955423e915c 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
@@ -26,13 +26,15 @@ class AutoBisectStagingTestApi(recipe_test_api.RecipeTestApi):
A value of 1 indicates pre-regression,
A value of 7 indicates post-regression,
Neither, need more data.
+ A value of 404 forces NEED_MORE_DATA regardless
"""
values_a = data[rev_a.commit_hash][:rev_a.test_run_count]
values_b = data[rev_b.commit_hash][:rev_b.test_run_count]
result = revision_state.FAIL_TO_REJECT
- if rev_a.test_run_count < 15 and rev_b.test_run_count < 15:
+ if (rev_a.test_run_count < 15 and rev_b.test_run_count < 15) or (
+ 404 in values_a + values_b):
result = revision_state.NEED_MORE_DATA
elif ((1 in values_a and 7 in values_b) or
(7 in values_a and 1 in values_b)):

Powered by Google App Engine
This is Rietveld 408576698