Skip base::string16 if not necessary for WebString <-> ASCII conversion

Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16 conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895
Committed: https://crrev.com/a0d5ac61931de6d57d2f7c2a619177986d4d5e0e
Cr-Commit-Position: refs/heads/master@{#429834}

[kinuko, 2016-11-02 17:33:11]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 17:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 20:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 20:59:59]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-11-03 00:53:27]

Description was changed from

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- ascii() ... returns ascii std::string, which skips string16 conversion
  for 8-bit cases
- containsOnlyASCII() ... this should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=(I'll file one)
==========

to

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases (it DCHECKs internally if it contains non-ascii chars, unlike
  WTFString::ascii() which returns string with '?' chars for non-ascii chars)
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=(I'll file one)
==========

[kinuko, 2016-11-03 00:53:27]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[kinuko, 2016-11-03 00:55:51]

Description was changed from

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases (it DCHECKs internally if it contains non-ascii chars, unlike
  WTFString::ascii() which returns string with '?' chars for non-ascii chars)
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=(I'll file one)
==========

to

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=(I'll file one)
==========

[kinuko, 2016-11-03 01:11:46]

Split from the other mime refactoring patch
(https://codereview.chromium.org/2444873002/).  What do you think?

[dcheng, 2016-11-03 05:38:08]

LGTM

[esprehn, 2016-11-03 05:47:11]

lgtm

[kinuko, 2016-11-03 08:19:59]

Description was changed from

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=(I'll file one)
==========

to

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895
==========

[kinuko, 2016-11-03 08:19:59]

kinuko@chromium.org changed reviewers:
+ chcunningham@chromium.org

[kinuko, 2016-11-03 08:20:45]

chcunningham@: could you review changes in media/blink?

[kinuko, 2016-11-03 08:29:28]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 08:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 10:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 10:30:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[chcunningham, 2016-11-03 17:46:01]

lgtm

[kinuko, 2016-11-04 01:18:58]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-11-04 01:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, dcheng@chromium.org, chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/2469353003/#ps40001
(title: "minor fix")

[commit-bot: I haz the power, 2016-11-04 01:19:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:29:22]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2016-11-04 03:17:43]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:00:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kinuko, 2016-11-04 07:12:52]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-11-04 07:13:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 08:50:28]

Description was changed from

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895
==========

to

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895
==========

[commit-bot: I haz the power, 2016-11-04 08:50:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 08:53:19]

Description was changed from

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895
==========

to

==========
Skip base::string16 if not necessary for WebString <-> ASCII conversion

One common way to get ASCII string from WebString is to do
base::UTF16ToASCII(webString)

but this always goes through string16 even when webString only
contains ASCII and is already a 8-bit string (which is expected).

This patch adds following WebString methods to help optimizing
WebString <-> ASCII conversions:

- WebString::ascii() ... returns ascii std::string, which skips string16
conversion
  for 8-bit cases. Internally DCHECKs if it contains non-ascii chars
- WebString::containsOnlyASCII() ... should be more efficient than calling
  base::IsStringASCII() on WebString (which incurs string16 conversion)
- WebString::fromASCII() ... does same as fromLatin1() but with DCHECK

Split from https://codereview.chromium.org/2444873002/

BUG=661895

Committed: https://crrev.com/a0d5ac61931de6d57d2f7c2a619177986d4d5e0e
Cr-Commit-Position: refs/heads/master@{#429834}
==========

[commit-bot: I haz the power, 2016-11-04 08:53:21]

Patchset 3 (id:??) landed as
https://crrev.com/a0d5ac61931de6d57d2f7c2a619177986d4d5e0e
Cr-Commit-Position: refs/heads/master@{#429834}