content/renderer/render_view_browsertest.cc - Issue 2469353003: Skip base::string16 if not necessary for WebString <-> ASCII conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2469353003: Skip base::string16 if not necessary for WebString <-> ASCII conversion (Closed)

Patch Set: minor fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index b7af1d0db0f36852c73d9f52d05a7e277316a882..06b45c456b2265c92fb2c813f81f9ea1e9a3a7ab 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -1815,9 +1815,9 @@ TEST_F(RendererErrorPageTest, MAYBE_Suppresses) {

main_frame->didFailProvisionalLoad(web_frame, error,

blink::WebStandardCommit);

const int kMaxOutputCharacters = 22;

- EXPECT_EQ("", base::UTF16ToASCII(base::StringPiece16(

- WebFrameContentDumper::dumpWebViewAsText(

- view()->GetWebView(), kMaxOutputCharacters))));

+ EXPECT_EQ("", WebFrameContentDumper::dumpWebViewAsText(view()->GetWebView(),

+ kMaxOutputCharacters)

+ .ascii());

}

#if defined(OS_ANDROID)

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »