Convert Site Isolation Win bot to --isolate-extensions [2nd attempt].

content/test/BUILD.gn

Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index dfeb244563af855ad00adf2b196e212db4c0fb0f..ceb35e53f2010f419667b50cb9c5eb1b890ee8af 100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -723,6 +723,26 @@ test("content_browsertests") {
 
   data = []
 
+  # Adding all //testing/buildbot/filters/*.content_browsertests.*filter files
+  # as a dependency.
+  #
+  # They might not be used on all platforms (e.g. there is no mac bot coverage
+  # for --site-per-process today), but for simplicity we just include all of
+  # them below (doing this should help avoid unpleasant surprises when a bot
+  # config is switched in testing/buildbot/chromium.fyi.json without
+  # corresponding dependency changes here - see https://crbug.com/661447).
+  #
+  # To refresh, run the following command in bash:
+  # $ for i in $( \
+  #     find testing/buildbot/filters -name '*.content_browsertests.*filter'); \
+  #   do echo "    \"//$i\","; done | sort
+  data += [

[brettw, 2016/11/04 22:13:09]

It seems bad to duplicate this. Can you add a BUILD.gn file to the filters
directory?

You should be able to make a source set with data = [ ... ] in it and then
reference it in the dependencies from the targets you need it for.

[Łukasz Anforowicz, 2016/11/04 23:27:59]

Done.
Okay.  Initially I wondered about using "group", but I see in the docs that it
doesn't support "data" variable, so it is probably indeed safer + better to go
with source sets.

+    "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter",
+    "//testing/buildbot/filters/cast-linux.content_browsertests.filter",
+    "//testing/buildbot/filters/isolate-extensions.content_browsertests.filter",
+    "//testing/buildbot/filters/site-per-process.content_browsertests.filter",
+  ]
+
   data_deps = [
     "//content/shell:pak",
     "//third_party/mesa:osmesa",
@@ -761,7 +781,6 @@ test("content_browsertests") {
   }
 
   if (is_win || is_linux || is_android) {
-    data += [ "//testing/buildbot/filters/site-per-process.content_browsertests.filter" ]
   }
 
   if (is_win) {
@@ -784,7 +803,6 @@ test("content_browsertests") {
 
   if (is_linux) {
     sources += [ "../zygote/zygote_browsertest.cc" ]
-    data += [ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter" ]
   }
 
   if (is_android) {