Convert Site Isolation Win bot to --isolate-extensions [2nd attempt].

content/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
@@ skipping 705 matching lines @@
     "//ui/gfx/geometry",
     "//ui/gl",
     "//ui/gl:test_support",
     "//ui/resources",
     "//ui/shell_dialogs",
     "//ui/snapshot",
   ]
 
   data = []
 
+  # Adding all //testing/buildbot/filters/*.content_browsertests.*filter files
+  # as a dependency.
+  #
+  # They might not be used on all platforms (e.g. there is no mac bot coverage
+  # for --site-per-process today), but for simplicity we just include all of
+  # them below (doing this should help avoid unpleasant surprises when a bot
+  # config is switched in testing/buildbot/chromium.fyi.json without
+  # corresponding dependency changes here - see https://crbug.com/661447).
+  #
+  # To refresh, run the following command in bash:
+  # $ for i in $( \
+  #     find testing/buildbot/filters -name '*.content_browsertests.*filter'); \
+  #   do echo "    \"//$i\","; done | sort
+  data += [

[brettw, 2016/11/04 22:13:09]

It seems bad to duplicate this. Can you add a BUILD.gn file to the filters
directory?

You should be able to make a source set with data = [ ... ] in it and then
reference it in the dependencies from the targets you need it for.

[Łukasz Anforowicz, 2016/11/04 23:27:59]

Done.
Okay.  Initially I wondered about using "group", but I see in the docs that it
doesn't support "data" variable, so it is probably indeed safer + better to go
with source sets.

+    "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter",
+    "//testing/buildbot/filters/cast-linux.content_browsertests.filter",
+    "//testing/buildbot/filters/isolate-extensions.content_browsertests.filter",
+    "//testing/buildbot/filters/site-per-process.content_browsertests.filter",
+  ]
+
   data_deps = [
     "//content/shell:pak",
     "//third_party/mesa:osmesa",
   ]
 
   if (enable_plugins) {
     deps += [
       "//ppapi/host",
       "//ppapi/proxy",
       "//ppapi/proxy:ipc",
@@ skipping 18 matching lines @@
       "//net/tools/testserver/",
       "//ppapi/tests/test_case.html",
       "//ppapi/tests/test_page.css",
       "//third_party/pyftpdlib/",
       "//third_party/pywebsocket/",
       "//third_party/tlslite/",
     ]
   }
 
   if (is_win || is_linux || is_android) {
-    data += [ "//testing/buildbot/filters/site-per-process.content_browsertests.filter" ]
   }
 
   if (is_win) {
     sources += [ "../browser/accessibility/accessibility_win_browsertest.cc" ]
 
     deps += [
       "//content/app/strings",
       "//net:net_resources",
       "//third_party/WebKit/public:resources",
       "//third_party/iaccessible2",
       "//third_party/isimpledom",
     ]
 
     libs = [ "oleacc.lib" ]
 
     if (symbol_level != 0) {
       data += [ "$root_out_dir/content_browsertests.exe.pdb" ]
     }
   }
 
   if (is_linux) {
     sources += [ "../zygote/zygote_browsertest.cc" ]
-    data += [ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter" ]
   }
 
   if (is_android) {
     sources += [
       "../browser/accessibility/android_granularity_movement_browsertest.cc",
       "../browser/media/session/audio_focus_delegate_android_browsertest.cc",
       "../shell/android/browsertests_apk/content_browser_tests_jni_onload.cc",
     ]
     sources -= [
       "../browser/battery_status/battery_monitor_impl_browsertest.cc",
@@ skipping 900 matching lines @@
   if (is_android) {
     deps += [ "//testing/android/native_test:native_test_native_code" ]
   }
 }
 
 group("fuzzers") {
   deps = [
     "//content/test/fuzzer",
   ]
 }