Issue 246933008: Update TermsOfServiceTest.TermsOfServiceScreen test to stop using 'screen' as JS variable name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246933008: Update TermsOfServiceTest.TermsOfServiceScreen test to stop using 'screen' as JS variable name (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
stevenjb, Andrew T Wilson (Slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update TermsOfServiceTest.TermsOfServiceScreen test to stop using 'screen' as JS variable name Update TermsOfServiceTest.TermsOfServiceScreen test to stop using 'screen' as JS variable name. This hides window.screen and will no longer work once Blink is updated so that window.screen is no longer replaceable. BUG=364937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265738

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/policy/device_local_account_browsertest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/246933008/1

6 years, 8 months ago (2014-04-23 19:45:49 UTC) #4

Message was sent while issue was closed.

Change committed as 265738

Expand Messages | Collapse Messages