Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

Issue 246933008: Update TermsOfServiceTest.TermsOfServiceScreen test to stop using 'screen' as JS variable name (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/device_local_account_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
index 6c51c189fa354eb5e849569078896192ba2e2c95..88afef7fbd3ff72e2928ae7eb53a7f44ce7bfffe 100644
--- a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
+++ b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
@@ -1305,9 +1305,9 @@ IN_PROC_BROWSER_TEST_P(TermsOfServiceTest, TermsOfServiceScreen) {
ASSERT_TRUE(contents);
std::string json;
ASSERT_TRUE(content::ExecuteScriptAndExtractString(contents,
- "var screen = document.getElementById('terms-of-service');"
+ "var screenElement = document.getElementById('terms-of-service');"
"function SendReplyIfDownloadDone() {"
- " if (screen.classList.contains('tos-loading'))"
+ " if (screenElement.classList.contains('tos-loading'))"
" return false;"
" var status = {};"
" status.heading = document.getElementById('tos-heading').textContent;"
@@ -1317,7 +1317,7 @@ IN_PROC_BROWSER_TEST_P(TermsOfServiceTest, TermsOfServiceScreen) {
" document.getElementById('tos-content-heading').textContent;"
" status.content ="
" document.getElementById('tos-content-main').textContent;"
- " status.error = screen.classList.contains('error');"
+ " status.error = screenElement.classList.contains('error');"
" status.acceptEnabled ="
" !document.getElementById('tos-accept-button').disabled;"
" domAutomationController.send(JSON.stringify(status));"
@@ -1327,7 +1327,7 @@ IN_PROC_BROWSER_TEST_P(TermsOfServiceTest, TermsOfServiceScreen) {
"var observer = new MutationObserver(SendReplyIfDownloadDone);"
"if (!SendReplyIfDownloadDone()) {"
" var options = { attributes: true, attributeFilter: [ 'class' ] };"
- " observer.observe(screen, options);"
+ " observer.observe(screenElement, options);"
"}",
&json));
scoped_ptr<base::Value> value_ptr(base::JSONReader::Read(json));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698