Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 2469303002: 📰Open Downloads suggestions externally when appropriate (Closed)
Patch Set: whitespace Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
index 24cea687dd97bd318537c8f4bcbebda0e68f4e02..ef13be8b6cd1f94ad5cb5c793409f206148a8b42 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
@@ -7,6 +7,8 @@
import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsCardLayout.ContentSuggestionsCardLayoutEnum;
+import java.io.File;
+
/**
* Represents the data for an article card on the NTP.
*/
@@ -41,7 +43,7 @@
/** The position of this article within its section. */
public final int mPosition;
- /** The position of this article in the complete list. Populated by NewTabPageAdapter.*/
+ /** The position of this article in the complete list. Populated by NewTabPageAdapter. */
public int mGlobalPosition = -1;
/** The layout that should be used to display the snippet. */
@@ -66,10 +68,13 @@
/** Whether the linked article represents a downloaded asset. */
public boolean mIsDownloadedAsset;
- /** The path to the downloaded asset (only for download asset articles).*/
+ /** The path to the downloaded asset (only for download asset articles). */
private String mDownloadAssetPath;
- /** The mime type of the downloaded asset (only for download asset articles).*/
+ /** The downloaded asset (only for download asset articles). */
+ private File mFile;
+
+ /** The mime type of the downloaded asset (only for download asset articles). */
private String mDownloadAssetMimeType;
/**
@@ -163,14 +168,12 @@ public void setOfflineStatusChangeRunnable(Runnable runnable) {
}
/**
- * Returns the file path of the downloaded asset. May only be called if mIsDownloadedAsset is
- * true.
+ * @return the downloaded asset. May only be called if mIsDownloadedAsset is {@code true}.
*/
- // TODO(tschumann): If this always gets converted into an URI, we should drop this field and
- // simply use mUrl.
- public String getDownloadAssetPath() {
+ public File getDownloadAssetFile() {
assert mIsDownloadedAsset;
- return mDownloadAssetPath;
+ if (mFile == null) mFile = new File(mDownloadAssetPath);
+ return mFile;
}
/** Returns the mime type of the download asset. May only be called if mIsDownloadAsset is true.

Powered by Google App Engine
This is Rietveld 408576698