Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2469303002: 📰Open Downloads suggestions externally when appropriate (Closed)
Patch Set: whitespace Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 2153bd1ec61d8c75501904510e4b3910f67d48d1..ddebff806b428838e611109c62d0248188fae6b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -347,6 +347,13 @@ public void trackSnippetCategoryActionClick(int category, int position) {
public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
+
+ if (article.mIsDownloadedAsset) {
+ DownloadUtils.openFile(
+ article.getDownloadAssetFile(), article.getDownloadAssetMimeType(), false);
+ return;
+ }
+
NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory);
LoadUrlParams loadUrlParams =
new LoadUrlParams(article.mUrl, PageTransition.AUTO_BOOKMARK);

Powered by Google App Engine
This is Rietveld 408576698