Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2469253002: MIPS64: Port `ARM64: [turbofan] Avoid zero-extension after a 32-bit load` (Closed)

Created:
4 years, 1 month ago by ivica.bogosavljevic
Modified:
4 years, 1 month ago
Reviewers:
miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Port `ARM64: [turbofan] Avoid zero-extension after a 32-bit load` Port f07d2cdd6a3e73f49b7e15976062f6448f70983a Original commit message: A load instruction will implicitely clear the top 32 bits when writing to a W register. This patch avoids generating a `mov` instruction to zero-extend the result in this case. For example, this occurs in the generated code for dispatching to the next bytecode in the interpreter: kind = BYTECODE_HANDLER name = LdaZero compiler = turbofan Instructions (size = 36) 0x32e64c60 0 add x19, x19, #0x1 (1) 0x32e64c64 4 ldrb w0, [x20, x19] 0x32e64c68 8 mov w0, w0 ^^^^^^^^^^ 0x32e64c6c 12 lsl x0, x0, #3 0x32e64c70 16 ldr x1, [x21, x0] 0x32e64c74 20 movz x0, #0x0 0x32e64c78 24 br x1 Committed: https://crrev.com/4125ba8bbd856ecb0a95476f4a51cf0715d62ac1 Cr-Commit-Position: refs/heads/master@{#40758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 2 chunks +86 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ivica.bogosavljevic
PTAL
4 years, 1 month ago (2016-11-02 09:55:38 UTC) #3
miran.karic
lgtm
4 years, 1 month ago (2016-11-03 13:27:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469253002/1
4 years, 1 month ago (2016-11-04 10:27:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 10:50:34 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4125ba8bbd856ecb0a95476f4a51cf0715d62ac1
Cr-Commit-Position: refs/heads/master@{#40758}

Powered by Google App Engine
This is Rietveld 408576698