Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1950013003: ARM64: [turbofan] Avoid zero-extension after a 32-bit load (Closed)

Created:
4 years, 7 months ago by Pierre Langlois
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: [turbofan] Avoid zero-extension after a 32-bit load A load instruction will implicitely clear the top 32 bits when writing to a W register. This patch avoids generating a `mov` instruction to zero-extend the result in this case. For example, this occurs in the generated code for dispatching to the next bytecode in the interpreter: kind = BYTECODE_HANDLER name = LdaZero compiler = turbofan Instructions (size = 36) 0x32e64c60 0 add x19, x19, #0x1 (1) 0x32e64c64 4 ldrb w0, [x20, x19] 0x32e64c68 8 mov w0, w0 ^^^^^^^^^^ 0x32e64c6c 12 lsl x0, x0, #3 0x32e64c70 16 ldr x1, [x21, x0] 0x32e64c74 20 movz x0, #0x0 0x32e64c78 24 br x1 BUG= Committed: https://crrev.com/f07d2cdd6a3e73f49b7e15976062f6448f70983a Cr-Commit-Position: refs/heads/master@{#36038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +111 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Pierre Langlois
4 years, 7 months ago (2016-05-04 15:40:42 UTC) #2
Benedikt Meurer
LGTM.
4 years, 7 months ago (2016-05-04 17:38:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950013003/1
4 years, 7 months ago (2016-05-04 17:39:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:35:15 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:36:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f07d2cdd6a3e73f49b7e15976062f6448f70983a
Cr-Commit-Position: refs/heads/master@{#36038}

Powered by Google App Engine
This is Rietveld 408576698