[recipe_modules/test_results] Refactor the logic of generating full json results files to a method

[recipe_modules/test_results] Refactor the logic of generating full json results files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.


*Reland: this includes the fix & unittest that would catch the error.

BUG=649762
Committed: https://chromium.googlesource.com/chromium/tools/build/+/181b3c9d2f25c7caa6980daec07ac280144b6cf5

[nednguyen, 2016-11-02 22:56:09]

nednguyen@google.com changed reviewers:
+ estaab@chromium.org, kbr@chromium.org, phajdan.jr@chromium.org

[nednguyen, 2016-11-02 22:56:09]

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
(right):

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:59:
test_results_map = get_results_map_from_json(results_json)
The test also helps catch this bug.

[nednguyen, 2016-11-02 22:56:38]

Description was changed from

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.


*Reland: this includes the fix & unittest that would catch the error.

BUG=649762
==========

to

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.


*Reland: this includes the fix & unittest that would catch the error.

BUG=649762
==========

[Ken Russell (switch to Gerrit), 2016-11-02 23:46:48]

Seems fine -- LGTM -- but I'm not an owner. Good test.

[estaab, 2016-11-03 15:05:09]

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
(right):

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:56:
Args:
Can you add a "Returns:" section documenting the return value and rename this
generate_json_results_files() since it returns two filenames?

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:57:
results_json: the raw test results object that follows GTest format.
The comment mentions this is in gtest format - is that true? Can we name this
parameter gtest_json?

[nednguyen, 2016-11-03 21:34:58]

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
(right):

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:56:
Args:
On 2016/11/03 15:05:09, estaab wrote:
> Can you add a "Returns:" section documenting the return value and rename this
> generate_json_results_files() since it returns two filenames?

Done.

https://codereview.chromium.org/2469233003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:57:
results_json: the raw test results object that follows GTest format.
On 2016/11/03 15:05:09, estaab wrote:
> The comment mentions this is in gtest format - is that true? Can we name this
> parameter gtest_json?

Done.

[estaab, 2016-11-03 23:25:09]

The CQ bit was checked by estaab@chromium.org

[estaab, 2016-11-03 23:25:09]

lgtm

[estaab, 2016-11-03 23:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2469233003/#ps40001
(title: "Address estaab comments")

[commit-bot: I haz the power, 2016-11-03 23:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:34:39]

Description was changed from

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.


*Reland: this includes the fix & unittest that would catch the error.

BUG=649762
==========

to

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.


*Reland: this includes the fix & unittest that would catch the error.

BUG=649762

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/181b3c9d2f25c7caa698...
==========

[commit-bot: I haz the power, 2016-11-03 23:34:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/181b3c9d2f25c7caa698...