Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py

Issue 2469233003: [recipe_modules/test_results] Refactor the logic of generating full json results files to a method (Closed)
Patch Set: Address estaab comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/test_results/resources/upload_test_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
diff --git a/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py b/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
index 11a32c8ea5d89afdd566c44400229665132d2b44..1b62f377872d26b2fa14072da3cf7c92179f869a 100755
--- a/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
+++ b/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
@@ -6,8 +6,18 @@
"""Unit tests for upload_test_results.py."""
import json
+import os
+import shutil
+import sys
+import tempfile
import unittest
+sys.path.insert(0, os.path.join(
+ os.path.dirname(__file__), '..', '..', '..', '..'))
+import common.env
+common.env.Install()
+import mock
+
import upload_test_results
@@ -68,6 +78,42 @@ class UploadTestResultsTest(unittest.TestCase):
self.assertEquals(results['Disabled.Test'][0].DISABLED,
results['Skipped.Test'][0].modifier)
+ @mock.patch('test_results_uploader.upload_test_results')
+ def test_main(self, uploader_mock):
+ contents = {
+ 'per_iteration_data': [{
+ 'Fake.Test': [
+ {'status': 'XXX', 'elapsed_time_ms': 1000},
+ ],
+ }],
+ }
+ result_directory = tempfile.mkdtemp()
+ input_json_file_path = os.path.join(result_directory, 'results.json')
+ with open(input_json_file_path, 'w') as f:
+ json.dump(contents, f)
+ try:
+ upload_test_results.main([
+ '--test-type=foo',
+ '--input-json=%s' % input_json_file_path,
+ '--results-directory=%s' % result_directory,
+ '--test-results-server=foo',
+ '--master-name=sauron',
+ ])
+ files = [
+ ('full_results.json',
+ os.path.join(result_directory,
+ upload_test_results.FULL_RESULTS_FILENAME)),
+ ('times_ms.json',
+ os.path.join(result_directory,
+ upload_test_results.TIMES_MS_FILENAME))]
+ uploader_mock.assert_called_with(
+ 'foo',
+ [('builder', 'DUMMY_BUILDER_NAME'),
+ ('testtype', 'foo'),
+ ('master', 'sauron')], files, 120)
+ finally:
+ shutil.rmtree(result_directory)
+
if __name__ == '__main__':
unittest.main()
« no previous file with comments | « scripts/slave/recipe_modules/test_results/resources/upload_test_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698