Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2469153003: DevTools: Remove ghost text from FilteredListWidget (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove ghost text from FilteredListWidget This also converts the FilteredListWidget test to be a unit test, and adds some extra functionality to inspector-unit-test.js to handle this. BUG=660725 Committed: https://crrev.com/37d52357e9b7260b8fe4244d3835d67fef4553c3 Cr-Commit-Position: refs/heads/master@{#429453}

Patch Set 1 #

Patch Set 2 : Exit test on rejected promise #

Messages

Total messages: 8 (3 generated)
einbinder
This is the reformatted version of https://codereview.chromium.org/2458383003.
4 years, 1 month ago (2016-11-02 18:22:40 UTC) #2
lushnikov
rs lgtm
4 years, 1 month ago (2016-11-02 20:39:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469153003/20001
4 years, 1 month ago (2016-11-02 20:57:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 23:37:44 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 23:41:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37d52357e9b7260b8fe4244d3835d67fef4553c3
Cr-Commit-Position: refs/heads/master@{#429453}

Powered by Google App Engine
This is Rietveld 408576698