Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2458383003: DevTools: Remove ghost text from FilteredListWidget (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove ghost text from FilteredListWidget This also converts the FilteredListWidget test to be a unit test, and adds some extra functionality to inspector-unit-test.js to handle this. BUG=660725

Patch Set 1 #

Total comments: 2

Messages

Total messages: 4 (2 generated)
einbinder
ptal
4 years, 1 month ago (2016-10-31 23:54:31 UTC) #2
lushnikov
4 years, 1 month ago (2016-11-01 22:35:32 UTC) #4
lgtm

https://codereview.chromium.org/2458383003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js
(right):

https://codereview.chromium.org/2458383003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js:85:
reject("Cannot find method to override: " + methodName);
let's end test?

https://codereview.chromium.org/2458383003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2458383003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:153:
_autocomplete: function()
"We can change this to _tabKeyPressed"(Joel)

Powered by Google App Engine
This is Rietveld 408576698