content_shell: Remove deps for resources only needed at runtime.

content_shell: Remove deps for resources only needed at runtime.

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#data_deps_Non_linked-dependencies
> data_deps are non-linked runtime dependencies. They are built and available
> at runtime.

The .pak and font resources are not linked but rather just needed at
runtime.

Split out of https://codereview.chromium.org/2460503002/

BUG=524758
Committed: https://crrev.com/3d9a6345c105cd59cb62f6c5aa9649ac4560b0b0
Cr-Commit-Position: refs/heads/master@{#429517}

[mithro, 2016-11-02 04:41:49]

tansell@chromium.org changed reviewers:
+ dpranke@google.com, jochen@chromium.org

[mithro, 2016-11-02 04:41:50]

Hi!

This CL was split out of https://codereview.chromium.org/2460503002/.

It removes the duplicate reference to resources which *should* only be needed at
runtime.

Tim 'mithro' Ansell

[mithro, 2016-11-02 06:01:52]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 06:02:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 07:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 07:18:06]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-11-02 11:01:14]

lgtm

[Dirk Pranke, 2016-11-02 16:44:41]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-02 16:44:42]

lgtm

[mithro, 2016-11-03 02:57:54]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 03:04:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 03:08:06]

Description was changed from

==========
content_shell: Remove deps for resources only needed at runtime.

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...
> data_deps are non-linked runtime dependencies. They are built and available
> at runtime.

The .pak and font resources are not linked but rather just needed at
runtime.

Split out of https://codereview.chromium.org/2460503002/

BUG=524758
==========

to

==========
content_shell: Remove deps for resources only needed at runtime.

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...
> data_deps are non-linked runtime dependencies. They are built and available
> at runtime.

The .pak and font resources are not linked but rather just needed at
runtime.

Split out of https://codereview.chromium.org/2460503002/

BUG=524758

Committed: https://crrev.com/3d9a6345c105cd59cb62f6c5aa9649ac4560b0b0
Cr-Commit-Position: refs/heads/master@{#429517}
==========

[commit-bot: I haz the power, 2016-11-03 03:08:08]

Patchset 1 (id:??) landed as
https://crrev.com/3d9a6345c105cd59cb62f6c5aa9649ac4560b0b0
Cr-Commit-Position: refs/heads/master@{#429517}

[Robert Sesek, 2016-11-21 16:59:31]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2016-11-21 16:59:31]

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
File components/test_runner/BUILD.gn (left):

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
components/test_runner/BUILD.gn:197: deps += [ ":test_runner_bundle_data" ]
I think this broke Mac content_shell. Did you try a clobber build and then run
WebKit layout tests?

[mithro, 2016-11-22 06:02:36]

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
File components/test_runner/BUILD.gn (left):

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
components/test_runner/BUILD.gn:197: deps += [ ":test_runner_bundle_data" ]
On 2016/11/21 16:59:31, Robert Sesek wrote:
> I think this broke Mac content_shell. Did you try a clobber build and then run
> WebKit layout tests?

No I did not. This seems to be passing fine on the bots?

[Robert Sesek, 2016-11-22 16:50:23]

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
File components/test_runner/BUILD.gn (left):

https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
components/test_runner/BUILD.gn:197: deps += [ ":test_runner_bundle_data" ]
On 2016/11/22 06:02:35, mithro wrote:
> On 2016/11/21 16:59:31, Robert Sesek wrote:
> > I think this broke Mac content_shell. Did you try a clobber build and then
run
> > WebKit layout tests?
> 
> No I did not. This seems to be passing fine on the bots?

The bots don't clobber by default. But your change here stops the AHEM fonts
from being copied into the Content Shell.app bundle, and after a clobber, this
will cause WebKit layout tests to fail.

I uploaded this dummy CL and send a `git cl try -c` (for clobber) to
demonstrate: https://codereview.chromium.org/2515253005/.

The test all hit this DLOG(FATAL):
https://cs.chromium.org/chromium/src/content/shell/app/blink_test_platform_su...

[Robert Sesek, 2016-11-23 18:53:33]

On 2016/11/22 16:50:23, Robert Sesek wrote:
>
https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
> File components/test_runner/BUILD.gn (left):
> 
>
https://codereview.chromium.org/2469073004/diff/1/components/test_runner/BUIL...
> components/test_runner/BUILD.gn:197: deps += [ ":test_runner_bundle_data" ]
> On 2016/11/22 06:02:35, mithro wrote:
> > On 2016/11/21 16:59:31, Robert Sesek wrote:
> > > I think this broke Mac content_shell. Did you try a clobber build and then
> run
> > > WebKit layout tests?
> > 
> > No I did not. This seems to be passing fine on the bots?
> 
> The bots don't clobber by default. But your change here stops the AHEM fonts
> from being copied into the Content Shell.app bundle, and after a clobber, this
> will cause WebKit layout tests to fail.
> 
> I uploaded this dummy CL and send a `git cl try -c` (for clobber) to
> demonstrate: https://codereview.chromium.org/2515253005/.
> 
> The test all hit this DLOG(FATAL):
>
https://cs.chromium.org/chromium/src/content/shell/app/blink_test_platform_su...

Do you intend to fix this, or should we revert this CL?

[mithro, 2016-11-23 23:21:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2522323002/ by tansell@chromium.org.

The reason for reverting is: Broke Mac builds of content shell. See Robert
Sesek's comments..