Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: components/test_runner/BUILD.gn

Issue 2469073004: content_shell: Remove deps for resources only needed at runtime. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/BUILD.gn
diff --git a/components/test_runner/BUILD.gn b/components/test_runner/BUILD.gn
index 96827b19137c357e7d427a966354bb096e499df8..7938f70e63299adc642d87c9d9fc46d27059ef3c 100644
--- a/components/test_runner/BUILD.gn
+++ b/components/test_runner/BUILD.gn
@@ -107,7 +107,6 @@ component("test_runner") {
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
deps = [
- ":resources",
"//base:base",
"//base:i18n",
"//cc",
@@ -190,23 +189,18 @@ if (is_mac) {
}
group("resources") {
- deps = []
data_deps = []
if (is_mac) {
- deps += [ ":test_runner_bundle_data" ]
Robert Sesek 2016/11/21 16:59:31 I think this broke Mac content_shell. Did you try
mithro 2016/11/22 06:02:35 No I did not. This seems to be passing fine on the
Robert Sesek 2016/11/22 16:50:23 The bots don't clobber by default. But your change
data_deps += [ ":test_runner_bundle_data" ]
} else {
- deps += [ ":copy_ahem" ]
data_deps += [ ":copy_ahem" ]
}
if (use_x11) {
- deps += [ ":copy_x11_fonts" ]
data_deps += [ ":copy_x11_fonts" ]
}
if (is_android) {
- deps += [ ":copy_android_fonts" ]
data_deps += [ ":copy_android_fonts" ]
}
}
« no previous file with comments | « no previous file | content/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698