Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2469013004: Put all reasons in MainThreadScrollingReason into one enum (Closed)

Created:
4 years, 1 month ago by wychen
Modified:
4 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put all reasons in MainThreadScrollingReason into one enum This is to avoid a false positive in enum type equality checking in https://codereview.chromium.org/2469993002/. No intended binary or behavior changes. BUG=661401 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/48e95c8ed1c285048d172fdd00361673f808bfee Cr-Commit-Position: refs/heads/master@{#429226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 1 chunk +27 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
wychen
PTAL
4 years, 1 month ago (2016-11-02 04:21:25 UTC) #3
aelias_OOO_until_Jul13
Seems legit, I don't see any reason why it was written the previous way (Dana ...
4 years, 1 month ago (2016-11-02 06:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469013004/1
4 years, 1 month ago (2016-11-02 06:56:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 07:11:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48e95c8ed1c285048d172fdd00361673f808bfee Cr-Commit-Position: refs/heads/master@{#429226}
4 years, 1 month ago (2016-11-02 07:13:40 UTC) #11
wychen
4 years, 1 month ago (2016-11-02 21:29:50 UTC) #12
Message was sent while issue was closed.
The CQ was way too fast. It turned out that none of the bots compiled the code,
because the GN file was incomplete. Filed a bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=661774

Powered by Google App Engine
This is Rietveld 408576698