cc: Fix enum style conformance in InputHandler.

cc: Fix enum style conformance in InputHandler.

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3590476fbc8b9d8680bbc0a033025ab6daa5fe26
Cr-Commit-Position: refs/heads/master@{#370780}

[danakj, 2016-01-19 23:23:53]

Description was changed from

==========
cc: Fix enum style conformance in InputHandler.

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
==========

to

==========
cc: Fix enum style conformance in InputHandler.

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-01-19 23:24:23]

I wanted to delete WebMainThreadScrollingReason too, but it's used in core/
which I don't think is allowed to use cc/. So maybe ScrollingCoordinator should
be in platform/ instead.

[danakj, 2016-01-19 23:24:53]

On 2016/01/19 23:24:23, danakj wrote:
> I wanted to delete WebMainThreadScrollingReason too, but it's used in core/
> which I don't think is allowed to use cc/. So maybe ScrollingCoordinator
should
> be in platform/ instead.

Though perhaps it should be a wrapper around the cc one instead of duplicating
it..

[aelias_OOO_until_Jul13, 2016-01-19 23:40:33]

lgtm

[danakj, 2016-01-19 23:43:05]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-19 23:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604053002/1

[commit-bot: I haz the power, 2016-01-20 01:00:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:00:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2016-01-20 15:17:27]

Thanks a lot!

Incidentally
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
is what I modeled much of this style from.

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
cc/input/main_thread_scrolling_reason.h:26: enum : uint32_t {
kMaxNonTransientScrollingReason = kPageOverlay };
These will be used after your other change.

See
https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
for example.

Some of these constants were only used on the blink side, but once the enums are
merged, everything should be used.

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
cc/input/main_thread_scrolling_reason.h:28: // Transcient scrolling reasons.
Can you fix my spelling here too?
"Transient"

Thanks!

[tdresser, 2016-01-20 15:17:34]

On 2016/01/20 15:17:27, tdresser wrote:
> Thanks a lot!
> 
> Incidentally
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> is what I modeled much of this style from.
> 
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> File cc/input/main_thread_scrolling_reason.h (right):
> 
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> cc/input/main_thread_scrolling_reason.h:26: enum : uint32_t {
> kMaxNonTransientScrollingReason = kPageOverlay };
> These will be used after your other change.
> 
> See
>
https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
> for example.
> 
> Some of these constants were only used on the blink side, but once the enums
are
> merged, everything should be used.
> 
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> cc/input/main_thread_scrolling_reason.h:28: // Transcient scrolling reasons.
> Can you fix my spelling here too?
> "Transient"
> 
> Thanks!

LGTM

[tdresser, 2016-01-20 15:39:49]

On 2016/01/20 15:17:34, tdresser wrote:
> On 2016/01/20 15:17:27, tdresser wrote:
> > Thanks a lot!
> > 
> > Incidentally
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > is what I modeled much of this style from.
> > 
> >
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> > File cc/input/main_thread_scrolling_reason.h (right):
> > 
> >
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> > cc/input/main_thread_scrolling_reason.h:26: enum : uint32_t {
> > kMaxNonTransientScrollingReason = kPageOverlay };
> > These will be used after your other change.
> > 
> > See
> >
>
https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
> > for example.
> > 
> > Some of these constants were only used on the blink side, but once the enums
> are
> > merged, everything should be used.
> > 
> >
>
https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
> > cc/input/main_thread_scrolling_reason.h:28: // Transcient scrolling reasons.
> > Can you fix my spelling here too?
> > "Transient"
> > 
> > Thanks!
> 
> LGTM

Looks like https://codereview.chromium.org/1601243003/ is going to be a bit
annoying.
Sorry!

[danakj, 2016-01-20 21:00:01]

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
cc/input/main_thread_scrolling_reason.h:26: enum : uint32_t {
kMaxNonTransientScrollingReason = kPageOverlay };
On 2016/01/20 15:17:27, tdresser wrote:
> These will be used after your other change.
> 
> See
>
https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
> for example.
> 
> Some of these constants were only used on the blink side, but once the enums
are
> merged, everything should be used.

Done.

https://codereview.chromium.org/1604053002/diff/1/cc/input/main_thread_scroll...
cc/input/main_thread_scrolling_reason.h:28: // Transcient scrolling reasons.
On 2016/01/20 15:17:27, tdresser wrote:
> Can you fix my spelling here too?
> "Transient"
> 
> Thanks!

Done.

[danakj, 2016-01-20 22:01:24]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-20 22:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1604053002/#ps40001
(title: "enumname: .")

[commit-bot: I haz the power, 2016-01-20 22:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604053002/40001

[commit-bot: I haz the power, 2016-01-20 23:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:26:54]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-01-20 23:33:56]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-20 23:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1604053002/#ps60001
(title: "enumname: more-rebase")

[commit-bot: I haz the power, 2016-01-20 23:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604053002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604053002/60001

[commit-bot: I haz the power, 2016-01-21 03:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 03:34:37]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[danakj, 2016-01-21 19:05:06]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-21 19:05:07]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1604053002/#ps80001
(title: "enumname: enumcompare-rebase")

[commit-bot: I haz the power, 2016-01-21 19:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604053002/80001

[commit-bot: I haz the power, 2016-01-21 19:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 19:18:37]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-01-21 19:20:32]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-21 19:20:32]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1604053002/#ps100001
(title: "enumname: fixcasts")

[commit-bot: I haz the power, 2016-01-21 19:22:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604053002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604053002/100001

[commit-bot: I haz the power, 2016-01-21 20:49:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-21 20:50:35]

Description was changed from

==========
cc: Fix enum style conformance in InputHandler.

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Fix enum style conformance in InputHandler.

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3590476fbc8b9d8680bbc0a033025ab6daa5fe26
Cr-Commit-Position: refs/heads/master@{#370780}
==========

[commit-bot: I haz the power, 2016-01-21 20:50:36]

Patchset 6 (id:??) landed as
https://crrev.com/3590476fbc8b9d8680bbc0a033025ab6daa5fe26
Cr-Commit-Position: refs/heads/master@{#370780}