Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246893004: Moves SelectFaviconFrames from history to favicon_base component. (Closed)

Created:
6 years, 8 months ago by jif
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Moves SelectFaviconFrames from history to the favicon_base component. In order to create a favicon component, we are removing dependencies on chrome/. TBR=bsalomon1 BUG=359592 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266547

Patch Set 1 : #

Patch Set 2 : Rebased. #

Patch Set 3 : Fixed 64 bits. #

Patch Set 4 : Fixed 64 bits v2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -351 lines) Patch
M chrome/browser/favicon/favicon_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/history/select_favicon_frames.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/history/select_favicon_frames.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M chrome/browser/history/select_favicon_frames_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/update_shortcut_worker_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/favicon_base.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/favicon_base/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/favicon_base/select_favicon_frames.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/favicon_base/select_favicon_frames.cc View 1 2 3 9 chunks +32 lines, -27 lines 0 comments Download

Messages

Total messages: 53 (0 generated)
jif
ptal
6 years, 8 months ago (2014-04-22 14:52:51 UTC) #1
jif
ptal
6 years, 8 months ago (2014-04-22 16:15:28 UTC) #2
sdefresne
lgtm
6 years, 8 months ago (2014-04-22 17:58:20 UTC) #3
sdefresne
+sky for OWNERS
6 years, 8 months ago (2014-04-22 17:58:47 UTC) #4
sky
LGTM
6 years, 8 months ago (2014-04-22 19:40:54 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-22 20:10:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/20001
6 years, 8 months ago (2014-04-22 20:12:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 20:13:16 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/history/history_backend.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-22 20:13:16 UTC) #9
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 09:09:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/40001
6 years, 8 months ago (2014-04-24 09:10:10 UTC) #11
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 09:51:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 10:06:18 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 12:02:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 12:02:15 UTC) #15
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 12:04:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 12:05:13 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 12:14:33 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 12:14:34 UTC) #19
jif
On 2014/04/24 12:14:34, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-24 12:57:58 UTC) #20
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 12:58:04 UTC) #21
bsalomon_chromium
On 2014/04/24 12:57:58, jif wrote: > On 2014/04/24 12:14:34, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-24 13:13:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 13:41:24 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:18:37 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 14:18:37 UTC) #25
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 14:24:53 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 14:25:46 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:45:27 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 14:45:27 UTC) #29
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 14:50:59 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 14:52:07 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:29:43 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 16:29:44 UTC) #33
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-24 16:44:46 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-24 16:46:27 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:07:08 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 21:07:09 UTC) #37
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-25 08:05:22 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 8 months ago (2014-04-25 08:30:34 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 08:32:00 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-26 08:32:00 UTC) #41
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 08:33:32 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/60001
6 years, 7 months ago (2014-04-28 08:34:04 UTC) #43
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 09:21:02 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/80001
6 years, 7 months ago (2014-04-28 09:21:56 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 09:56:21 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 09:56:22 UTC) #47
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 10:44:02 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/100001
6 years, 7 months ago (2014-04-28 10:44:43 UTC) #49
jif
The CQ bit was unchecked by jif@chromium.org
6 years, 7 months ago (2014-04-28 13:29:35 UTC) #50
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 13:29:42 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/246893004/100001
6 years, 7 months ago (2014-04-28 13:33:24 UTC) #52
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 13:51:31 UTC) #53
Message was sent while issue was closed. 
Change committed as 266547

Powered by Google App Engine
This is Rietveld 408576698