components/favicon_base.gypi - Issue 246893004: Moves SelectFaviconFrames from history to favicon_base component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base.gypi

Issue 246893004: Moves SelectFaviconFrames from history to favicon_base component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed 64 bits v2. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon_base.gypi

diff --git a/components/favicon_base.gypi b/components/favicon_base.gypi

index 105b356c6e206dbf2ab6372c80e27a1956c98d84..a46b289cee7ea92739a67d2dc1a599b3de076362 100644

--- a/components/favicon_base.gypi

+++ b/components/favicon_base.gypi

@@ -9,12 +9,15 @@

'type': 'static_library',

'dependencies': [

'../base/base.gyp:base',

+ '../skia/skia.gyp:skia',

'../ui/gfx/gfx.gyp:gfx',

'../url/url.gyp:url_lib',

'sources': [

'favicon_base/favicon_types.cc',

'favicon_base/favicon_types.h',

+ 'favicon_base/select_favicon_frames.cc',

+ 'favicon_base/select_favicon_frames.h',

'include_dirs': [

'..',

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/favicon_base/DEPS » ('j') | no next file with comments »