Don't call CloseBubble multiple times in ExtensionInstalledBubbleView

chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index f5202d99cc40de4d1bdee5d6f817520b7c19d090..8555bd01d3e06b6449abcae64f297a56003a65bc 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -261,7 +261,8 @@ void ExtensionInstalledBubbleView::OnSignInLinkClicked() {
   chrome::ShowBrowserSignin(
       browser(),
       signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE);
-  CloseBubble();
+  // Showing the sign-in UI will cause the bubble to close.
+  CHECK(GetWidget()->IsClosed());

[Peter Kasting, 2016/11/03 00:56:39]

Nit: Why CHECK and not DCHECK?  Generally we should prefer DCHECK, unless this
is a security vulnerability or a temporary debugging measure; see
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
.

[Evan Stade, 2016/11/03 15:55:28]

Devlin has expressed a preference for CHECK. I'm happy to change it to DCHECK.

 }
 
 void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
@@ -273,7 +274,8 @@ void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
   chrome::NavigateParams params(
       chrome::GetSingletonTabNavigateParams(browser(), GURL(configure_url)));
   chrome::Navigate(&params);
-  CloseBubble();
+  // Navigating will cause the bubble to close.
+  CHECK(GetWidget()->IsClosed());
 }
 
 gfx::Size ExtensionInstalledBubbleView::GetIconSize() const {