Don't call CloseBubble multiple times in ExtensionInstalledBubbleView

chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/user_metrics_action.h"
@@ skipping 243 matching lines @@
   if (controller_->options() & ExtensionInstalledBubble::HOW_TO_MANAGE) {
     AddChildView(CreateLabel(
         l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALLED_MANAGE_INFO)));
   }
 }
 
 void ExtensionInstalledBubbleView::OnSignInLinkClicked() {
   chrome::ShowBrowserSignin(
       browser(),
       signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE);
-  CloseBubble();
+  // Showing the sign-in UI will cause the bubble to close.
+  CHECK(GetWidget()->IsClosed());

[Peter Kasting, 2016/11/03 00:56:39]

Nit: Why CHECK and not DCHECK?  Generally we should prefer DCHECK, unless this
is a security vulnerability or a temporary debugging measure; see
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
.

[Evan Stade, 2016/11/03 15:55:28]

Devlin has expressed a preference for CHECK. I'm happy to change it to DCHECK.

 }
 
 void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
                                                int event_flags) {
   DCHECK_EQ(manage_shortcut_, source);
 
   std::string configure_url = chrome::kChromeUIExtensionsURL;
   configure_url += chrome::kExtensionConfigureCommandsSubPage;
   chrome::NavigateParams params(
       chrome::GetSingletonTabNavigateParams(browser(), GURL(configure_url)));
   chrome::Navigate(&params);
-  CloseBubble();
+  // Navigating will cause the bubble to close.
+  CHECK(GetWidget()->IsClosed());
 }
 
 gfx::Size ExtensionInstalledBubbleView::GetIconSize() const {
   const SkBitmap& bitmap = controller_->icon();
   // Scale down to 43x43, but allow smaller icons (don't scale up).
   gfx::Size size(bitmap.width(), bitmap.height());
   return size.width() > kIconSize || size.height() > kIconSize
              ? gfx::Size(kIconSize, kIconSize)
              : size;
 }
@@ skipping 67 matching lines @@
             ->browser_actions();
     return !container->animating();
   }
   return true;
 }
 
 // Implemented here to create the platform specific instance of the BubbleUi.
 std::unique_ptr<BubbleUi> ExtensionInstalledBubble::BuildBubbleUi() {
   return base::WrapUnique(new ExtensionInstalledBubbleUi(this));
 }