Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2468863002: scheduler: Re-enable timer throttling for hidden frames (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years ago
Reviewers:
kinuko, Z_DONOTUSE, ojan
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Re-enable timer throttling for hidden frames Turn hidden timer throttling back now that the issue with Gmail pop-ups not working has been resolved by https://codereview.chromium.org/2272773002/. This patch also fixes a timer throttling related rebase error in a previous patch and adds new layout test that cover out-of-view timer and requestAnimationFrame throttling. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_Lhz8THHk2Q BUG=616519, 647393 Committed: https://crrev.com/1667f2eb188cac8da8dcb2fc84a8357fd94b5f61 Cr-Commit-Position: refs/heads/master@{#438227}

Patch Set 1 #

Patch Set 2 : Fix rebase errors and add layout tests #

Patch Set 3 : Test fixes #

Patch Set 4 : Null check #

Patch Set 5 : Rebased #

Patch Set 6 : Fix fetch tests #

Patch Set 7 : Rebased. #

Patch Set 8 : Rebased #

Messages

Total messages: 40 (28 generated)
Sami
4 years, 1 month ago (2016-11-01 11:05:31 UTC) #3
kinuko
lgtm
4 years, 1 month ago (2016-11-01 12:55:59 UTC) #4
Sami
Thanks! I've folded in a a fix for two lines that were accidentally removed during ...
4 years, 1 month ago (2016-11-11 13:11:07 UTC) #8
Z_DONOTUSE
lgtm
4 years, 1 month ago (2016-11-16 18:00:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468863002/100001
4 years, 1 month ago (2016-11-16 21:09:21 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-16 22:15:26 UTC) #27
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/1688130897aed95d32e3904a6aa10384414fbefe Cr-Commit-Position: refs/heads/master@{#432642}
4 years, 1 month ago (2016-11-16 22:20:39 UTC) #29
Sami
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2511283002/ by skyostil@chromium.org. ...
4 years, 1 month ago (2016-11-17 23:04:22 UTC) #30
Sami
The Gmail fix (cl/140339869) appears to be live now so let's give this another go.
4 years ago (2016-12-13 16:40:44 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468863002/140001
4 years ago (2016-12-13 16:41:24 UTC) #35
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years ago (2016-12-13 18:18:20 UTC) #38
commit-bot: I haz the power
4 years ago (2016-12-13 18:20:46 UTC) #40
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/1667f2eb188cac8da8dcb2fc84a8357fd94b5f61
Cr-Commit-Position: refs/heads/master@{#438227}

Powered by Google App Engine
This is Rietveld 408576698