Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2468833002: Count visible password fields on a page (Closed)
Patch Set: fix comment wrapping Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 7c8ff2c232a2ce5a4ea8f7e50742db16c87cc7b9..980e7c10e81729394cca1b96e7425fcfcccbb07d 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -164,6 +164,13 @@ class CORE_EXPORT LocalFrame final : public Frame,
return m_instrumentingAgents.get();
}
+ // LocalFrame maintains a counter of visible non-secure password
+ // fields in the frame. Used to notify the embedder when all visible
+ // non-secure passwords fields are no longer visible.
+ void incrementPasswordCount();
+ void decrementPasswordCount();
+ uint64_t passwordCount() const;
+
// =========================================================================
// All public functions below this point are candidates to move out of
// LocalFrame into another class.
@@ -270,6 +277,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
InterfaceProvider* const m_interfaceProvider;
InterfaceRegistry* const m_interfaceRegistry;
+
+ uint64_t m_passwordCount;
dcheng 2016/11/01 18:12:42 Yeah, let's put this on Document: this *should* ge
estark 2016/11/01 18:32:26 Done.
};
inline void LocalFrame::init() {

Powered by Google App Engine
This is Rietveld 408576698