Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2468833002: Count visible password fields on a page (Closed)
Patch Set: fix comment wrapping Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 // change. 157 // change.
158 // In addition, this function will always return true for a detached frame. 158 // In addition, this function will always return true for a detached frame.
159 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right 159 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right
160 // behavior for detached windows. 160 // behavior for detached windows.
161 bool isCrossOriginSubframe() const; 161 bool isCrossOriginSubframe() const;
162 162
163 InstrumentingAgents* instrumentingAgents() { 163 InstrumentingAgents* instrumentingAgents() {
164 return m_instrumentingAgents.get(); 164 return m_instrumentingAgents.get();
165 } 165 }
166 166
167 // LocalFrame maintains a counter of visible non-secure password
168 // fields in the frame. Used to notify the embedder when all visible
169 // non-secure passwords fields are no longer visible.
170 void incrementPasswordCount();
171 void decrementPasswordCount();
172 uint64_t passwordCount() const;
173
167 // ========================================================================= 174 // =========================================================================
168 // All public functions below this point are candidates to move out of 175 // All public functions below this point are candidates to move out of
169 // LocalFrame into another class. 176 // LocalFrame into another class.
170 177
171 // See GraphicsLayerClient.h for accepted flags. 178 // See GraphicsLayerClient.h for accepted flags.
172 String layerTreeAsText(unsigned flags = 0) const; 179 String layerTreeAsText(unsigned flags = 0) const;
173 180
174 void setPrinting(bool printing, 181 void setPrinting(bool printing,
175 const FloatSize& pageSize, 182 const FloatSize& pageSize,
176 const FloatSize& originalPageSize, 183 const FloatSize& originalPageSize,
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 270
264 float m_pageZoomFactor; 271 float m_pageZoomFactor;
265 float m_textZoomFactor; 272 float m_textZoomFactor;
266 273
267 bool m_inViewSourceMode; 274 bool m_inViewSourceMode;
268 275
269 Member<InstrumentingAgents> m_instrumentingAgents; 276 Member<InstrumentingAgents> m_instrumentingAgents;
270 277
271 InterfaceProvider* const m_interfaceProvider; 278 InterfaceProvider* const m_interfaceProvider;
272 InterfaceRegistry* const m_interfaceRegistry; 279 InterfaceRegistry* const m_interfaceRegistry;
280
281 uint64_t m_passwordCount;
dcheng 2016/11/01 18:12:42 Yeah, let's put this on Document: this *should* ge
estark 2016/11/01 18:32:26 Done.
273 }; 282 };
274 283
275 inline void LocalFrame::init() { 284 inline void LocalFrame::init() {
276 m_loader.init(); 285 m_loader.init();
277 } 286 }
278 287
279 inline LocalDOMWindow* LocalFrame::localDOMWindow() const { 288 inline LocalDOMWindow* LocalFrame::localDOMWindow() const {
280 return m_domWindow.get(); 289 return m_domWindow.get();
281 } 290 }
282 291
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 explicit ScopedFrameBlamer(LocalFrame*); 381 explicit ScopedFrameBlamer(LocalFrame*);
373 ~ScopedFrameBlamer(); 382 ~ScopedFrameBlamer();
374 383
375 private: 384 private:
376 Member<LocalFrame> m_frame; 385 Member<LocalFrame> m_frame;
377 }; 386 };
378 387
379 } // namespace blink 388 } // namespace blink
380 389
381 #endif // LocalFrame_h 390 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698