[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Committed: https://crrev.com/5567a9f0adf4cff00175c3102f081cf47f2d7bf8
Cr-Commit-Position: refs/heads/master@{#429447}

[chfremer, 2016-10-31 22:24:59]

Description was changed from

==========
Apply patch AddTypemap.diff

BUG=
==========

to

==========
[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2016-10-31 22:26:20]

chfremer@chromium.org changed reviewers:
+ mcasas@chromium.org

[chfremer, 2016-10-31 22:26:36]

mcasas@: PTAL

[chfremer, 2016-10-31 22:26:47]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 22:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:52:19]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-11-02 00:24:37]

lgtm % some mojo-dev taking a look at the mappings.

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/vide...
File services/video_capture/video_capture_device_factory_impl.h (right):

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/vide...
services/video_capture/video_capture_device_factory_impl.h:68:
media::VideoCaptureDeviceDescriptor descriptor_;
Can you make this const?

[chfremer, 2016-11-02 00:26:52]

chfremer@chromium.org changed reviewers:
+ dcheng@chromium.org

[chfremer, 2016-11-02 00:26:52]

dcheng@: PTAL type mappings

[dcheng, 2016-11-02 21:16:10]

mojo LGTM with nit addressed

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/publ...
File
services/video_capture/public/interfaces/video_capture_device_descriptor_struct_traits.h
(right):

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/publ...
services/video_capture/public/interfaces/video_capture_device_descriptor_struct_traits.h:150:
media::VideoCaptureDeviceDescriptor* output) {
Nit: please out of line this into a .cc.

[chfremer, 2016-11-02 21:32:15]

Addressed comments

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/publ...
File
services/video_capture/public/interfaces/video_capture_device_descriptor_struct_traits.h
(right):

https://codereview.chromium.org/2468663003/diff/1/services/video_capture/publ...
services/video_capture/public/interfaces/video_capture_device_descriptor_struct_traits.h:150:
media::VideoCaptureDeviceDescriptor* output) {
On 2016/11/02 21:16:10, dcheng wrote:
> Nit: please out of line this into a .cc.

Done.

[chfremer, 2016-11-02 21:32:29]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 21:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:14:56]

Dry run: This issue passed the CQ dry run.

[chfremer, 2016-11-02 23:15:25]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-11-02 23:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2468663003/#ps20001
(title: "dcheng's comments and formatting")

[commit-bot: I haz the power, 2016-11-02 23:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:22:47]

Description was changed from

==========
[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[commit-bot: I haz the power, 2016-11-02 23:22:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 23:24:28]

Description was changed from

==========
[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Add Mojo Typemap for VideoCaptureDeviceDescriptor

* Add Mojo typemap for VideoCaptureDeviceDescriptor

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1].

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

Committed: https://crrev.com/5567a9f0adf4cff00175c3102f081cf47f2d7bf8
Cr-Commit-Position: refs/heads/master@{#429447}
==========

[commit-bot: I haz the power, 2016-11-02 23:24:29]

Patchset 2 (id:??) landed as
https://crrev.com/5567a9f0adf4cff00175c3102f081cf47f2d7bf8
Cr-Commit-Position: refs/heads/master@{#429447}