[Mojo Video Capture] Simplify API and some cleanups

[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes sense because media::VideoCaptureParams has extra fields that are making the API confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the service guarantees that pixel_format is always I420, and pixel_storage is always CPU.
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the struct struct mojom::VideoCaptureSettings. This makes it easier to understand what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Committed: https://crrev.com/475ef228d5701e3f80a405bdf077a880f1e309a5
Cr-Commit-Position: refs/heads/master@{#428820}

[chfremer, 2016-10-27 23:34:20]

Description was changed from

==========
Fix after merge


Merge branch 'Part_2_1' into Part_2_2


Merge branch 'master' into Part_2_1


Revert Mojo enum VideoPixelFormat to native


xhwang's comments


Fix dependency issues


Merge branch 'Part_2_1' into Part_2_2


Fix dependency issues


presubmit


Replace static cast with EnumTraits<VideoPixelFormat>


Redo changes based on types that have moved to media/capture


Merge branch 'master' into Part_2_1


Merge branch 'master' into Part_2_1


Merge branch 'Part_2_1' into Part_2_2


Fixed merge


Merge branch 'Part_2_1' into Part_2_2


Merge branch 'master' into Part_2_1


mcasas' comments


Merge branch 'master' into Part_2_1


Merge branch 'Part_1' into Part_2_1


Merge branch 'master' into Part_1


Apply patch for part2_2


Move Mojo structs/enums/typemaps to media


Remove method AsClientBuffer()


format


Merge branch 'master' into Part_1


Add TODO


mcasas comments


Merge branch 'Part_0' into Part_1


Merge branch 'DeviceClientMove2' into Part_0


Merge branch 'master' into DeviceClientMove2


* Rename a class * formatting


Merge branch 'Part_0' into Part_1


Merge branch 'DeviceClientMove2' into Part_0


Merge branch 'master' into DeviceClientMove2


fix presubmit


Merge branch 'Part_0' into Part_1


mcasas' comments


fix presubmit


Merge branch 'DeviceClientMove2' into Part_0


mcasas@ comments


Merge branch 'Part_0' into Part_1


Merge branch 'DeviceClientMove2' into Part_0


Merge branch 'BufferPoolRefactor' into DeviceClientMove2


Merge branch 'master' into BufferPoolRefactor


Fix build of content_unittest


mcasas' comments


Apply patch part1.diff


Apply patch for Part0


Reverted unintentional changes


Apply patch DeviceClientMove


Merge branch 'master' into BufferPoolRefactor


Add mcasas@ as owner for extraced code


mcasas' comments


Merge branch 'master' into BufferPoolRefactor


Merge branch 'DeviceClientRefactor' into BufferPoolRefactor


Merge branch 'master' into DeviceClientRefactor


format


Fix errors from merge


Merge branch 'DeviceClientRefactor' into BufferPoolRefactor


Remove unused interface


Merge branch 'master' into DeviceClientRefactor


miu's comments


* Renamed class PostOnIOThreadVideoFrameReceiver to VideoFrameReceiverOnIOThread
in order to adhere to naming schema of putting the name of the implemented
interface before a postfix expressing the specialization. * Make constructor
explicit.


* Rename VideoCaptureBufferPool to VideoCaptureBufferPoolImpl * Fix tests in
content_unittests


mcasas' comments


mcasas' & emircan's comments


Merge branch 'master' into DeviceClientRefactor


mcasas' comments


Fixed change that was lost in merge conflict/moving code to file


Fix merge/naming issues.


Merge branch 'DeviceClientRefactor' into BufferPoolRefactor


Apple method name changes to Mock


Merge branch 'master' into DeviceClientRefactor


Merge branch 'DeviceClientRefactor' into BufferPoolRefactor


Merge branch 'master' into DeviceClientRefactor


Merge branch 'DeviceClientRefactor' into BufferPoolRefactor


Merge branch 'master' into DeviceClientRefactor


Move nested classes out of VideoCaptureBufferPool into separate files.


Extracted logic of posting on Browser IO thread from VideoCaptureDeviceClient in
order to break dependency on browser_thread.h/cc.


Use new interface ThreadAccessor to break dependency of VideoCaptureDeviceClient
from browser_thread.h/cc.


Extract interface VideoCaptureJpegDecoder from class VideoCaptureGpuJpegDecoder.
Add interface VideoCaptureJpegDecoderFactory.


Extract methods from class class VideoCaptureController called by
VideoCaptureDeviceClient into a new interface VideoFrameReceiver. Extract
methods from class class VideoCaptureBufferPool called by
VideoCaptureDeviceClient into a new interface VideoCaptureBufferPoolInterface.

BUG=
==========

to

==========
[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture
Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes
sense because media::VideoCaptureParams has extra fields that are making the API
confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the
service guarantees that pixel_format is always I420, and pixel_storage is always
CPU. 
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the
struct struct mojom::VideoCaptureSettings. This makes it easier to understand
what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2016-10-27 23:36:14]

Patchset #1 (id:1) has been deleted

[chfremer, 2016-10-27 23:43:05]

chfremer@chromium.org changed reviewers:
+ mcasas@chromium.org

[chfremer, 2016-10-27 23:43:06]

mcasas@: PTAL

[mcasas, 2016-10-28 17:43:24]

lgtm

[chfremer, 2016-10-31 18:03:34]

chfremer@chromium.org changed reviewers:
+ rockot@chromium.org, tsepez@chromium.org

[chfremer, 2016-10-31 18:03:35]

rockot@: Please RS chromium_bindings_configuration.gni
tsepez@: Please RS *.mojom

[Tom Sepez, 2016-10-31 19:24:01]

RS LGTM

[Ken Rockot(use gerrit already), 2016-10-31 19:27:05]

rs lgtm

[chfremer, 2016-10-31 19:40:36]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:41:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:13:13]

Dry run: This issue passed the CQ dry run.

[chfremer, 2016-10-31 21:23:30]

The CQ bit was checked by chfremer@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:23:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:30:30]

Description was changed from

==========
[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture
Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes
sense because media::VideoCaptureParams has extra fields that are making the API
confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the
service guarantees that pixel_format is always I420, and pixel_storage is always
CPU. 
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the
struct struct mojom::VideoCaptureSettings. This makes it easier to understand
what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture
Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes
sense because media::VideoCaptureParams has extra fields that are making the API
confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the
service guarantees that pixel_format is always I420, and pixel_storage is always
CPU. 
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the
struct struct mojom::VideoCaptureSettings. This makes it easier to understand
what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[commit-bot: I haz the power, 2016-10-31 21:30:31]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-31 21:32:41]

Description was changed from

==========
[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture
Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes
sense because media::VideoCaptureParams has extra fields that are making the API
confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the
service guarantees that pixel_format is always I420, and pixel_storage is always
CPU. 
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the
struct struct mojom::VideoCaptureSettings. This makes it easier to understand
what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Simplify API and some cleanups

* Rename tests MockDeviceVideoCaptureServiceTest -> MockDeviceTest.
* Instead of using struct media::VideoCaptureParams as part of the Video Capture
Mojo API, introduce a new struct video_capture::VideoCaptureSettings. This makes
sense because media::VideoCaptureParams has extra fields that are making the API
confusing.
The extra fields |pixel_format| and |pixel_storage| are not needed because the
service guarantees that pixel_format is always I420, and pixel_storage is always
CPU.
* Move loose parameters of mojom::VideoCaptureDeviceProxy::Start() into the
struct struct mojom::VideoCaptureSettings. This makes it easier to understand
what the parameters mean.
* Move mojom::VideoCaptureDeviceDescriptor to its own *.mojom file
* Cosmetic cleanups

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.7.3

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

Committed: https://crrev.com/475ef228d5701e3f80a405bdf077a880f1e309a5
Cr-Commit-Position: refs/heads/master@{#428820}
==========

[commit-bot: I haz the power, 2016-10-31 21:32:42]

Patchset 1 (id:??) landed as
https://crrev.com/475ef228d5701e3f80a405bdf077a880f1e309a5
Cr-Commit-Position: refs/heads/master@{#428820}