Fix bug in keeping capture in sync during destruction

Fix bug in keeping capture in sync during destruction

It's possible when capture is lost the window losing focus gets
destroyed. This patch guards against that by not relying on the
lost_capture window, instead CaptureControllerMus adds itself as an
observer for the window with focus and if that window is destroyed
resets state.

In hopes of keeping the size of WindowTreeClient down I moved capture
code into its own class.

Test for this will come when aura tests are parameterized to work with
both backends.

BUG=659155
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/e865fb99e4e29280049bc397cdb27e61adce4700
Cr-Commit-Position: refs/heads/master@{#428794}

[sky, 2016-10-31 16:34:24]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 17:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:03:20]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msw, 2016-10-31 17:56:21]

lgtm with minor comment nits.

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
File ui/aura/mus/capture_synchronizer.cc (right):

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.cc:35: // Don't immediatley set
|capture_client_|. It's possible the change will be
nit: immediately.

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.cc:63: return;  // Happens if window deleted
during notification.
nit: 'the window is deleted'

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
File ui/aura/mus/capture_synchronizer.h (right):

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.h:45: // Internal implementation when capture
changes. Adds/removes observer as
nit: s/when/for/?

[sky, 2016-10-31 18:00:17]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-31 18:00:17]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2468493002/#ps60001
(title: "feedback")

[sky, 2016-10-31 18:00:32]

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
File ui/aura/mus/capture_synchronizer.cc (right):

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.cc:35: // Don't immediatley set
|capture_client_|. It's possible the change will be
On 2016/10/31 17:56:20, msw wrote:
> nit: immediately.

Done.

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.cc:63: return;  // Happens if window deleted
during notification.
On 2016/10/31 17:56:20, msw wrote:
> nit: 'the window is deleted'

Done.

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
File ui/aura/mus/capture_synchronizer.h (right):

https://codereview.chromium.org/2468493002/diff/40001/ui/aura/mus/capture_syn...
ui/aura/mus/capture_synchronizer.h:45: // Internal implementation when capture
changes. Adds/removes observer as
On 2016/10/31 17:56:20, msw wrote:
> nit: s/when/for/?

Done.

[commit-bot: I haz the power, 2016-10-31 18:00:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:34:49]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sky, 2016-10-31 20:04:56]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:05:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:38:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-31 20:41:06]

Description was changed from

==========
Fix bug in keeping capture in sync during destruction

It's possible when capture is lost the window losing focus gets
destroyed. This patch guards against that by not relying on the
lost_capture window, instead CaptureControllerMus adds itself as an
observer for the window with focus and if that window is destroyed
resets state.

In hopes of keeping the size of WindowTreeClient down I moved capture
code into its own class.

Test for this will come when aura tests are parameterized to work with
both backends.

BUG=659155
TEST=none
R=msw@chromium.org
==========

to

==========
Fix bug in keeping capture in sync during destruction

It's possible when capture is lost the window losing focus gets
destroyed. This patch guards against that by not relying on the
lost_capture window, instead CaptureControllerMus adds itself as an
observer for the window with focus and if that window is destroyed
resets state.

In hopes of keeping the size of WindowTreeClient down I moved capture
code into its own class.

Test for this will come when aura tests are parameterized to work with
both backends.

BUG=659155
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/e865fb99e4e29280049bc397cdb27e61adce4700
Cr-Commit-Position: refs/heads/master@{#428794}
==========

[commit-bot: I haz the power, 2016-10-31 20:41:07]

Patchset 4 (id:??) landed as
https://crrev.com/e865fb99e4e29280049bc397cdb27e61adce4700
Cr-Commit-Position: refs/heads/master@{#428794}