Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: ui/aura/mus/capture_synchronizer.cc

Issue 2468493002: Fix bug in keeping capture in sync during destruction (Closed)
Patch Set: feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/aura/mus/capture_synchronizer.h ('k') | ui/aura/mus/capture_synchronizer_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/aura/mus/capture_synchronizer.h"
6
7 #include "base/auto_reset.h"
8 #include "services/ui/public/interfaces/window_tree.mojom.h"
9 #include "ui/aura/client/capture_client.h"
10 #include "ui/aura/mus/capture_synchronizer_delegate.h"
11 #include "ui/aura/mus/window_mus.h"
12 #include "ui/aura/window.h"
13
14 namespace aura {
15
16 CaptureSynchronizer::CaptureSynchronizer(CaptureSynchronizerDelegate* delegate,
17 ui::mojom::WindowTree* window_tree,
18 client::CaptureClient* capture_client)
19 : delegate_(delegate),
20 window_tree_(window_tree),
21 capture_client_(capture_client) {
22 capture_client_->AddObserver(this);
23 }
24
25 CaptureSynchronizer::~CaptureSynchronizer() {
26 SetCaptureWindow(nullptr);
27 capture_client_->RemoveObserver(this);
28 }
29
30 void CaptureSynchronizer::SetCaptureFromServer(WindowMus* window) {
31 if (window == capture_window_)
32 return;
33
34 DCHECK(!setting_capture_);
35 // Don't immediately set |capture_client_|. It's possible the change will be
36 // rejected.
37 base::AutoReset<bool> capture_reset(&setting_capture_, true);
38 base::AutoReset<WindowMus*> window_setting_capture_to_reset(
39 &window_setting_capture_to_, window);
40 capture_client_->SetCapture(window ? window->GetWindow() : nullptr);
41 }
42
43 void CaptureSynchronizer::SetCaptureWindow(WindowMus* window) {
44 if (capture_window_)
45 capture_window_->GetWindow()->RemoveObserver(this);
46 capture_window_ = window;
47 if (capture_window_)
48 capture_window_->GetWindow()->AddObserver(this);
49 }
50
51 void CaptureSynchronizer::OnWindowDestroying(Window* window) {
52 // The CaptureClient implementation handles resetting capture when a window
53 // is destroyed, but because of observer ordering this may be called first.
54 DCHECK_EQ(window, capture_window_->GetWindow());
55 SetCaptureWindow(nullptr);
56 // The server will release capture when a window is destroyed, so no need
57 // explicitly schedule a change.
58 }
59
60 void CaptureSynchronizer::OnCaptureChanged(Window* lost_capture,
61 Window* gained_capture) {
62 if (!gained_capture && !capture_window_)
63 return; // Happens if the window is deleted during notification.
64
65 WindowMus* gained_capture_mus = WindowMus::Get(gained_capture);
66 if (setting_capture_ && gained_capture_mus == window_setting_capture_to_) {
67 SetCaptureWindow(gained_capture_mus);
68 return;
69 }
70
71 const uint32_t change_id =
72 delegate_->CreateChangeIdForCapture(capture_window_);
73 WindowMus* old_capture_window = capture_window_;
74 SetCaptureWindow(gained_capture_mus);
75 if (capture_window_)
76 window_tree_->SetCapture(change_id, capture_window_->server_id());
77 else
78 window_tree_->ReleaseCapture(change_id, old_capture_window->server_id());
79 }
80
81 } // namespace aura
OLDNEW
« no previous file with comments | « ui/aura/mus/capture_synchronizer.h ('k') | ui/aura/mus/capture_synchronizer_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698