Ignore compress="gzip" on iOS. It breaks lots of internals pages

Ignore compress="gzip" on iOS. It breaks lots of internals pages

R=jyquinn@chromium.org
BUG=648241
Committed: https://crrev.com/f04f2c7751dc79860899643506094b68758d9de2
Cr-Commit-Position: refs/heads/master@{#429932}

[Jackie Quinn, 2016-11-04 01:38:50]

Thank you for this fix!

https://codereview.chromium.org/2468423006/diff/1/tools/grit/grit/node/includ...
File tools/grit/grit/node/include.py (right):

https://codereview.chromium.org/2468423006/diff/1/tools/grit/grit/node/includ...
tools/grit/grit/node/include.py:102: if wants_compression and 'is_ios' not in
root_defines:
s/'ios_ios' not in root_defines/self.GetRoot().target_platform != 'ios'

[Dan Beam, 2016-11-04 01:59:24]

dbeam@chromium.org changed reviewers:
+ thestig@chromium.org

[Dan Beam, 2016-11-04 01:59:25]

+thestig@ for owners

cq if lgty

https://codereview.chromium.org/2468423006/diff/1/tools/grit/grit/node/includ...
File tools/grit/grit/node/include.py (right):

https://codereview.chromium.org/2468423006/diff/1/tools/grit/grit/node/includ...
tools/grit/grit/node/include.py:102: if wants_compression and 'is_ios' not in
root_defines:
On 2016/11/04 01:38:50, Jackie Quinn wrote:
> s/'ios_ios' not in root_defines/self.GetRoot().target_platform != 'ios'

Done.

[Dan Beam, 2016-11-04 01:59:35]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2016-11-04 02:17:55]

lgtm whomp whomp

[Dan Beam, 2016-11-04 04:03:25]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 04:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:16:44]

Dry run: This issue passed the CQ dry run.

[Jackie Quinn, 2016-11-04 17:21:44]

On 2016/11/04 02:17:55, Lei Zhang wrote:
> lgtm whomp whomp

lgtm

[Dan Beam, 2016-11-04 17:23:44]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:24:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:29:56]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-04 17:36:52]

Description was changed from

==========
Ignore compress="gzip" on iOS. It breaks lots of internals pages

R=jyquinn@chromium.org
BUG=648241
==========

to

==========
Ignore compress="gzip" on iOS. It breaks lots of internals pages

R=jyquinn@chromium.org
BUG=648241

Committed: https://crrev.com/f04f2c7751dc79860899643506094b68758d9de2
Cr-Commit-Position: refs/heads/master@{#429932}
==========

[commit-bot: I haz the power, 2016-11-04 17:36:53]

Patchset 2 (id:??) landed as
https://crrev.com/f04f2c7751dc79860899643506094b68758d9de2
Cr-Commit-Position: refs/heads/master@{#429932}