tools/grit/grit/node/include.py - Issue 2468423006: Ignore compress="gzip" on iOS. It breaks lots of internals pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/node/include.py

Issue 2468423006: Ignore compress="gzip" on iOS. It breaks lots of internals pages (Closed)

Patch Set: fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit/node/include.py

diff --git a/tools/grit/grit/node/include.py b/tools/grit/grit/node/include.py

index 9383adec576eaa7b170ec4c5584a8d923bfbc8d6..46f1c07be156aa51548268ac80f8608a8314238a 100755

--- a/tools/grit/grit/node/include.py

+++ b/tools/grit/grit/node/include.py

@@ -97,7 +97,8 @@ class IncludeNode(base.Node):

# Note that the minifier will only do anything if a minifier command

# has been set in the command line.

data = minifier.Minify(data, filename)

- if 'compress' in self.attrs and self.attrs['compress'] == 'gzip':

+ use_gzip = self.attrs.get('compress', '') == 'gzip'

+ if use_gzip and self.GetRoot().target_platform != 'ios':

# We only use rsyncable compression on Linux.

# We exclude ChromeOS since ChromeOS bots are Linux based but do not have

# the --rsyncable option built in for gzip. See crbug.com/617950.

« no previous file with comments | « no previous file | no next file » | no next file with comments »