Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Issue 2468423005: Revert of Disable (temporarily) WebView Browsertests on Mac build bots. (Closed)

Created:
4 years, 1 month ago by wjmaclean
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable (temporarily) WebView Browsertests on Mac build bots. (patchset #1 id:1 of https://codereview.chromium.org/2433943003/ ) Reason for revert: This patch was only meant to be temporary. Time to re-enable the tests. Original issue's description: > Disable (temporarily) WebView Browsertests on Mac build bots. > > In order to investigate the causes of the windows-server crashes on the > Mac bots, this CL temporarily disables WebView browsertests on Mac. Once > their impact is better understood, they will be re-enabled. > > This CL is related to https://codereview.chromium.org/2414813002 which > just disabled the WebUI WebView browser tests. > > BUG=653353 > > Committed: https://crrev.com/0cfb5638a524e3bd0ce25d8bc5ab4c7187b3ab5e > Cr-Commit-Position: refs/heads/master@{#426254} TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653353 Committed: https://crrev.com/0921d355baacbff53a1dd4bd88ee48fa5f51bb61 Cr-Commit-Position: refs/heads/master@{#429663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
Created Revert of Disable (temporarily) WebView Browsertests on Mac build bots.
4 years, 1 month ago (2016-11-03 17:35:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468423005/1
4 years, 1 month ago (2016-11-03 17:36:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 19:11:17 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-03 19:12:00 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 19:16:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0921d355baacbff53a1dd4bd88ee48fa5f51bb61
Cr-Commit-Position: refs/heads/master@{#429663}

Powered by Google App Engine
This is Rietveld 408576698