Disable (temporarily) WebView browsertests on Mac.

Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
Committed: https://crrev.com/3a2ff0e84fc4bbdce80e09650492519ba8397d4f
Cr-Commit-Position: refs/heads/master@{#425090}

[wjmaclean, 2016-10-12 22:24:54]

Description was changed from

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
==========

to

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
==========

[wjmaclean, 2016-10-12 22:24:54]

wjmaclean@chromium.org changed reviewers:
+ thestig@chromium.org

[wjmaclean, 2016-10-12 22:25:07]

Tiny CL, ptal?

[Lei Zhang, 2016-10-12 22:42:06]

How long is "temporary" ?

https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):

https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
chrome/browser/ui/webui/webui_webview_browsertest.cc:26: #if !defined(OS_MACOSX)
Can you reference the bug?

[wjmaclean, 2016-10-13 11:25:14]

On 2016/10/12 22:42:06, Lei Zhang wrote:
> How long is "temporary" ?
> 
>
https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
> File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
> chrome/browser/ui/webui/webui_webview_browsertest.cc:26: #if
!defined(OS_MACOSX)
> Can you reference the bug?

I did reference the bug. I don't know how long temporary is, though erikchen@
and I had thought at least a few days, so we can observe the change in behaviour
on the bot.

[wjmaclean, 2016-10-13 11:25:43]

On 2016/10/13 11:25:14, wjmaclean wrote:
> On 2016/10/12 22:42:06, Lei Zhang wrote:
> > How long is "temporary" ?
> > 
> >
>
https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
> > File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2414813002/diff/1/chrome/browser/ui/webui/web...
> > chrome/browser/ui/webui/webui_webview_browsertest.cc:26: #if
> !defined(OS_MACOSX)
> > Can you reference the bug?
> 
> I did reference the bug. I don't know how long temporary is, though erikchen@
> and I had thought at least a few days, so we can observe the change in
behaviour
> on the bot.

Oh, sorry, you meant a comment in the code ...will do.

[Lei Zhang, 2016-10-13 17:25:03]

lgtm

[wjmaclean, 2016-10-13 17:33:58]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:10:52]

Description was changed from

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
==========

to

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
==========

[commit-bot: I haz the power, 2016-10-13 18:10:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 18:12:24]

Description was changed from

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353
==========

to

==========
Disable (temporarily) WebView browsertests on Mac.

In order to investigate the causes of the windows-server crashes on the
Mac bots, this CL temporarily disables WebView browsertests on Mac. Once
their impact is better understood, they will be re-enabled.

BUG=653353

Committed: https://crrev.com/3a2ff0e84fc4bbdce80e09650492519ba8397d4f
Cr-Commit-Position: refs/heads/master@{#425090}
==========

[commit-bot: I haz the power, 2016-10-13 18:12:25]

Patchset 2 (id:??) landed as
https://crrev.com/3a2ff0e84fc4bbdce80e09650492519ba8397d4f
Cr-Commit-Position: refs/heads/master@{#425090}