Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: chrome/android/java/res/layout/website_settings.xml

Issue 2468413002: Android: Add connection security summary to page info popup (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/website_settings.xml
diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml
index 9b082e00fb63bd7f5ea2c4b522cfc74d5515899c..ac2dd9d5a2323bec436d5046caba02036b1bac1a 100644
--- a/chrome/android/java/res/layout/website_settings.xml
+++ b/chrome/android/java/res/layout/website_settings.xml
@@ -29,11 +29,21 @@
android:ellipsize="end"
android:lineSpacingExtra="6dp"
android:paddingTop="16dp"
+ android:paddingBottom="16dp"
android:textAlignment="viewStart"
android:textColor="@color/url_emphasis_default_text"
android:textSize="16sp"/>
<TextView
+ android:id="@+id/website_settings_connection_summary"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:lineSpacingExtra="3dp"
Ted C 2016/11/03 20:49:48 should this have paddingTop="16dp" here? and no pa
tsergeant 2016/11/03 23:01:04 I'm not sure whether this should have the extra pa
+ android:textColor="@color/website_settings_popup_text"
+ android:textSize="16sp"
+ android:visibility="gone" />
+
+ <TextView
android:id="@+id/website_settings_connection_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"

Powered by Google App Engine
This is Rietveld 408576698