[Mac] Take Sierra RTL into account when laying out window buttons

[Mac] Take Sierra RTL into account when laying out window buttons

Sierra reverses the window buttons when launching programs in RTL
mode. We calculate the size between window buttons based on the gap
between the close and miniaturize buttons, but when the buttons are
reversed this is incorrect. The result is a large gap between buttons,
pushing one offscreen (see image in bug.)

BUG=662097
Committed: https://crrev.com/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5
Cr-Commit-Position: refs/heads/master@{#429684}

[lgrey, 2016-11-03 18:55:50]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org, mark@chromium.org

[lgrey, 2016-11-03 18:55:51]

PTAL :)

Elly for RTL, Mark for OWNERS

[Elly Fong-Jones, 2016-11-03 18:59:41]

lgtm

Nice! I love the unit tests.

[Mark Mentovai, 2016-11-03 19:38:12]

LGTM

[lgrey, 2016-11-03 19:42:41]

Thanks!

[lgrey, 2016-11-03 19:42:48]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2016-11-03 19:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2468373003/#ps20001
(title: "Add expectation that close button is left of miniaturize button in
original test")

[commit-bot: I haz the power, 2016-11-03 19:44:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:16:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 20:19:27]

Description was changed from

==========
[Mac] Take Sierra RTL into account when laying out window buttons

Sierra reverses the window buttons when launching programs in RTL
mode. We calculate the size between window buttons based on the gap
between the close and miniaturize buttons, but when the buttons are
reversed this is incorrect. The result is a large gap between buttons,
pushing one offscreen (see image in bug.)

BUG=662097
==========

to

==========
[Mac] Take Sierra RTL into account when laying out window buttons

Sierra reverses the window buttons when launching programs in RTL
mode. We calculate the size between window buttons based on the gap
between the close and miniaturize buttons, but when the buttons are
reversed this is incorrect. The result is a large gap between buttons,
pushing one offscreen (see image in bug.)

BUG=662097

Committed: https://crrev.com/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5
Cr-Commit-Position: refs/heads/master@{#429684}
==========

[commit-bot: I haz the power, 2016-11-03 20:19:28]

Patchset 2 (id:??) landed as
https://crrev.com/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5
Cr-Commit-Position: refs/heads/master@{#429684}