chrome/browser/ui/cocoa/framed_browser_window.mm - Issue 2468373003: [Mac] Take Sierra RTL into account when laying out window buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/framed_browser_window.mm

Issue 2468373003: [Mac] Take Sierra RTL into account when laying out window buttons (Closed)

Patch Set: Add expectation that close button is left of miniaturize button in original test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/framed_browser_window.mm

diff --git a/chrome/browser/ui/cocoa/framed_browser_window.mm b/chrome/browser/ui/cocoa/framed_browser_window.mm

index 2bd1cf99cc4baa9e22f5aacc6f1023b65f500a18..e482aab0b281d5cd68c9930c6e045b78f2bd8b02 100644

--- a/chrome/browser/ui/cocoa/framed_browser_window.mm

+++ b/chrome/browser/ui/cocoa/framed_browser_window.mm

@@ -135,6 +135,10 @@ const CGFloat kWindowGradientHeight = 24.0;

windowButtonsInterButtonSpacing_ =

NSMinX([miniaturizeButton_ frame]) - NSMaxX([closeButton_ frame]);

+ if (windowButtonsInterButtonSpacing_ < 0)

+ // Sierra RTL

+ windowButtonsInterButtonSpacing_ =

+ NSMinX([miniaturizeButton_ frame]) - NSMaxX([zoomButton_ frame]);

NSNotificationCenter* center = [NSNotificationCenter defaultCenter];

if (shouldUseFullSizeContentView) {

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/framed_browser_window_unittest.mm » ('j') | no next file with comments »