Added UnguessableToken.java .

Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=

Committed: https://crrev.com/d8b550c725757a369fd04dee74f5309ab5637569
Cr-Commit-Position: refs/heads/master@{#431342}

[liberato (no reviews please), 2016-11-02 22:08:07]

Description was changed from

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=
==========

to

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=
==========

[liberato (no reviews please), 2016-11-02 22:08:07]

liberato@chromium.org changed reviewers:
+ tguilbert@chromium.org

[liberato (no reviews please), 2016-11-02 22:10:51]

here's an attempt at wrapping UnguessableToken for use in java.

overall, i'm picturing native code creating a native token, and sending it to
java.  or, java receives a java token via binder, gives it to native, which then
constructs a native token with the same value.

one cannot create new entirely tokens in java, since i don't have a use for it
right now.  easy to add, i suppose.

thanks
-fl

[liberato (no reviews please), 2016-11-02 22:18:24]

https://codereview.chromium.org/2468353002/diff/40001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/UnguessableToken.java (right):

https://codereview.chromium.org/2468353002/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/UnguessableToken.java:51: public void
writeToParcel(Parcel dest, int flags) {
i need to add unit tests for these.  didn't see an easy way to write java-side
tests, so i'll probably need to add a private helper function.

[tguilbert, 2016-11-02 23:31:50]

LGTM % nits

(I don't have committer status yet FYI...)

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
File base/android/jni_unguessable_token.cc (right):

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
base/android/jni_unguessable_token.cc:15: return
Java_UnguessableToken_create(env, token.GetHighForSerialization(),
Can you add a DCHECK(token) here? One of the goals of UnguessableToken was to
prevent developers from accidentally not initializing their tokens before their
use.

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
base/android/jni_unguessable_token.cc:24: const uint64_t low =
Java_UnguessableToken_getLowForSerialization(env, token);
Can you add a DCHECK to make sure the token that was created is not empty?

[liberato (no reviews please), 2016-11-03 15:37:47]

Patchset #4 (id:60001) has been deleted

[liberato (no reviews please), 2016-11-03 15:39:38]

liberato@chromium.org changed reviewers:
+ nyquist@chromium.org

[liberato (no reviews please), 2016-11-03 15:42:30]

nyquist: PTAL as an owner of base/android .  thanks!

tguilbert: thanks for the comments.

thanks
-fl

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
File base/android/jni_unguessable_token.cc (right):

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
base/android/jni_unguessable_token.cc:15: return
Java_UnguessableToken_create(env, token.GetHighForSerialization(),
On 2016/11/02 23:31:50, tguilbert wrote:
> Can you add a DCHECK(token) here? One of the goals of UnguessableToken was to
> prevent developers from accidentally not initializing their tokens before
their
> use.

Done.

https://codereview.chromium.org/2468353002/diff/40001/base/android/jni_ungues...
base/android/jni_unguessable_token.cc:24: const uint64_t low =
Java_UnguessableToken_getLowForSerialization(env, token);
On 2016/11/02 23:31:50, tguilbert wrote:
> Can you add a DCHECK to make sure the token that was created is not empty?

Done.

[liberato (no reviews please), 2016-11-03 15:43:32]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:44:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 16:55:37]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[liberato (no reviews please), 2016-11-03 17:57:08]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:57:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 19:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 19:04:07]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-11-08 19:04:42]

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
File base/android/java/src/org/chromium/base/UnguessableToken.java (right):

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:18: *
base::UnguessableToken, then create a java object from it.  See
Nit: Java here and in the TODO

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:22: private long
mHigh;
final for these two fields.

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:60: final long
high = source.readLong();
Nit: unnecessary final here and below

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
File base/android/jni_unguessable_token.h (right):

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:5: #ifndef
BASE_ANDROID_JNI_UNGUESSABLE_TOKEN_H_
We usually use jni_foo_thing.h naming for things that have to do with our
handling of JNI itself, such as JavaRef, strings, numbers, arrays, etc., not for
wrapper classes around code with real business logic.

How about naming this unguessable_token_android.h? (similarly to
memory_pressure_listener_android.* in the same directory)

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:17: // Create a java UnguessableToken with
the same value as |token|.
Nit: Java

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:22: // Create a native UnguessableToken
from |token|.
Nit: Could you specify which Java type |token| must be?

[liberato (no reviews please), 2016-11-09 18:18:33]

thanks for the feedback.

-fl

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
File base/android/java/src/org/chromium/base/UnguessableToken.java (right):

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:18: *
base::UnguessableToken, then create a java object from it.  See
On 2016/11/08 19:04:42, nyquist wrote:
> Nit: Java here and in the TODO

Done.

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:22: private long
mHigh;
On 2016/11/08 19:04:42, nyquist wrote:
> final for these two fields.

Done.

https://codereview.chromium.org/2468353002/diff/100001/base/android/java/src/...
base/android/java/src/org/chromium/base/UnguessableToken.java:60: final long
high = source.readLong();
On 2016/11/08 19:04:42, nyquist wrote:
> Nit: unnecessary final here and below

Done.

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
File base/android/jni_unguessable_token.h (right):

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:5: #ifndef
BASE_ANDROID_JNI_UNGUESSABLE_TOKEN_H_
On 2016/11/08 19:04:42, nyquist wrote:
> We usually use jni_foo_thing.h naming for things that have to do with our
> handling of JNI itself, such as JavaRef, strings, numbers, arrays, etc., not
for
> wrapper classes around code with real business logic.
> 
> How about naming this unguessable_token_android.h? (similarly to
> memory_pressure_listener_android.* in the same directory)

thanks, Done.

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:17: // Create a java UnguessableToken with
the same value as |token|.
On 2016/11/08 19:04:42, nyquist wrote:
> Nit: Java

Done.

https://codereview.chromium.org/2468353002/diff/100001/base/android/jni_ungue...
base/android/jni_unguessable_token.h:22: // Create a native UnguessableToken
from |token|.
On 2016/11/08 19:04:42, nyquist wrote:
> Nit: Could you specify which Java type |token| must be?

Done.

[liberato (no reviews please), 2016-11-10 06:01:35]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 06:01:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 06:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 06:47:05]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-11-10 20:16:03]

lgtm

[liberato (no reviews please), 2016-11-10 20:31:34]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2016-11-10 20:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
tguilbert@chromium.org
Link to the patchset: https://codereview.chromium.org/2468353002/#ps140001
(title: "renamed unit test, comments.")

[commit-bot: I haz the power, 2016-11-10 20:32:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:41:37]

Description was changed from

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=
==========

to

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=
==========

[commit-bot: I haz the power, 2016-11-10 20:41:38]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-11-10 21:00:03]

Description was changed from

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=
==========

to

==========
Added UnguessableToken.java .

Added a java wrapper for base::UnguessableToken.  Native code can
start with a native UnguessableToken, and convert it to and from a
java UnguessableToken.

The java implementation is Parcelable, so that it can be sent via
binder easily.

TEST=jni_unguessable_token_unittest
BUG=

Committed: https://crrev.com/d8b550c725757a369fd04dee74f5309ab5637569
Cr-Commit-Position: refs/heads/master@{#431342}
==========

[commit-bot: I haz the power, 2016-11-10 21:00:04]

Patchset 7 (id:??) landed as
https://crrev.com/d8b550c725757a369fd04dee74f5309ab5637569
Cr-Commit-Position: refs/heads/master@{#431342}