Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: base/android/jni_unguessable_token.h

Issue 2468353002: Added UnguessableToken.java . (Closed)
Patch Set: added final for findbugs compilation failure Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BASE_ANDROID_JNI_UNGUESSABLE_TOKEN_H_
nyquist 2016/11/08 19:04:42 We usually use jni_foo_thing.h naming for things t
liberato (no reviews please) 2016/11/09 18:18:33 thanks, Done.
6 #define BASE_ANDROID_JNI_UNGUESSABLE_TOKEN_H_
7
8 #include <jni.h>
9
10 #include "base/android/scoped_java_ref.h"
11 #include "base/base_export.h"
12 #include "base/unguessable_token.h"
13
14 namespace base {
15 namespace android {
16
17 // Create a java UnguessableToken with the same value as |token|.
nyquist 2016/11/08 19:04:42 Nit: Java
liberato (no reviews please) 2016/11/09 18:18:33 Done.
18 BASE_EXPORT ScopedJavaLocalRef<jobject> CreateJavaUnguessableToken(
19 JNIEnv* env,
20 const base::UnguessableToken& token);
21
22 // Create a native UnguessableToken from |token|.
nyquist 2016/11/08 19:04:42 Nit: Could you specify which Java type |token| mus
liberato (no reviews please) 2016/11/09 18:18:33 Done.
23 BASE_EXPORT base::UnguessableToken ConvertFromJavaUnguessableToken(
24 JNIEnv* env,
25 const JavaRef<jobject>& token);
26
27 // Parcel |token| and unparcel it, and return the result. While this method is
28 // intended for facilitating unit tests, it results only in a clone of |token|.
29 BASE_EXPORT ScopedJavaLocalRef<jobject>
30 ParcelAndUnparcelUnguessableTokenForTesting(JNIEnv* env,
31 const JavaRef<jobject>& token);
32
33 } // namespace android
34 } // namespace base
35
36 #endif // BASE_ANDROID_JNI_UNGUESSABLE_TOKEN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698