Add components_browsertests and components_unittests runs with --enable-browser-side-navigation

Add components_browsertests and components_unittests runs with --enable-browser-side-navigation

Also add component_browsertests to (dbg) config in non-plznav since it
was missing.

R=jam@chromium.org

Committed: https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
Cr-Commit-Position: refs/heads/master@{#429655}

[scottmg, 2016-11-02 20:56:52]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:57:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:56:20]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-11-02 23:07:02]

[[ FWIW, neither interactive_ui_tests https://codereview.chromium.org/2469093004
nor extensions_browsertests https://codereview.chromium.org/2474733003 worked.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=661811 and
https://bugs.chromium.org/p/chromium/issues/detail?id=661812.
]]

[jam, 2016-11-03 18:24:00]

lgtm

[scottmg, 2016-11-03 18:24:22]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:25:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 18:34:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 18:45:31]

Description was changed from

==========
Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

Also add component_browsertests to (dbg) config in non-plznav since it
was missing.

R=jam@chromium.org
==========

to

==========
Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

Also add component_browsertests to (dbg) config in non-plznav since it
was missing.

R=jam@chromium.org

Committed: https://crrev.com/8097dff55c84516414ce944ee6bc5435807f4fbc
Cr-Commit-Position: refs/heads/master@{#429654}
==========

[commit-bot: I haz the power, 2016-11-03 18:45:32]

Patchset 1 (id:??) landed as
https://crrev.com/8097dff55c84516414ce944ee6bc5435807f4fbc
Cr-Commit-Position: refs/heads/master@{#429654}

[commit-bot: I haz the power, 2016-11-03 18:45:33]

Description was changed from

==========
Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

Also add component_browsertests to (dbg) config in non-plznav since it
was missing.

R=jam@chromium.org

Committed: https://crrev.com/8097dff55c84516414ce944ee6bc5435807f4fbc
Cr-Commit-Position: refs/heads/master@{#429654}
==========

to

==========
Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

Also add component_browsertests to (dbg) config in non-plznav since it
was missing.

R=jam@chromium.org

Committed: https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
Cr-Commit-Position: refs/heads/master@{#429655}
==========

[commit-bot: I haz the power, 2016-11-03 18:45:34]

Patchset 1 (id:??) landed as
https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
Cr-Commit-Position: refs/heads/master@{#429655}

[ynovikov, 2016-11-03 19:26:00]

On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> Cr-Commit-Position: refs/heads/master@{#429655}

This breaks presubmit:
** Presubmit ERRORS **
manage (0.18s) failed
chromium.linux.json: Linux Tests /
browser_side_navigation_components_browsertests is listed multiple times.

Can this be fixed / reverted? Thanks!

[ynovikov, 2016-11-03 19:29:13]

On 2016/11/03 19:26:00, ynovikov wrote:
> On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > Cr-Commit-Position: refs/heads/master@{#429655}
> 
> This breaks presubmit:
> ** Presubmit ERRORS **
> manage (0.18s) failed
> chromium.linux.json: Linux Tests /
> browser_side_navigation_components_browsertests is listed multiple times.
> 
> Can this be fixed / reverted? Thanks!

Actually, seems like this patch landed twice? Bug in commit-bot?

[scottmg, 2016-11-03 19:29:42]

On 2016/11/03 19:26:00, ynovikov wrote:
> On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > Cr-Commit-Position: refs/heads/master@{#429655}
> 
> This breaks presubmit:
> ** Presubmit ERRORS **
> manage (0.18s) failed
> chromium.linux.json: Linux Tests /
> browser_side_navigation_components_browsertests is listed multiple times.
> 
> Can this be fixed / reverted? Thanks!

I have no idea how that happened, sorry. Looking.

[scottmg, 2016-11-03 19:35:12]

On 2016/11/03 19:29:42, scottmg wrote:
> On 2016/11/03 19:26:00, ynovikov wrote:
> > On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > > Cr-Commit-Position: refs/heads/master@{#429655}
> > 
> > This breaks presubmit:
> > ** Presubmit ERRORS **
> > manage (0.18s) failed
> > chromium.linux.json: Linux Tests /
> > browser_side_navigation_components_browsertests is listed multiple times.
> > 
> > Can this be fixed / reverted? Thanks!
> 
> I have no idea how that happened, sorry. Looking.

I think the diff got applied incorrectly/twice??

[scottmg, 2016-11-03 19:37:13]

On 2016/11/03 19:35:12, scottmg wrote:
> On 2016/11/03 19:29:42, scottmg wrote:
> > On 2016/11/03 19:26:00, ynovikov wrote:
> > > On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > > > Cr-Commit-Position: refs/heads/master@{#429655}
> > > 
> > > This breaks presubmit:
> > > ** Presubmit ERRORS **
> > > manage (0.18s) failed
> > > chromium.linux.json: Linux Tests /
> > > browser_side_navigation_components_browsertests is listed multiple times.
> > > 
> > > Can this be fixed / reverted? Thanks!
> > 
> > I have no idea how that happened, sorry. Looking.
> 
> I think the diff got applied incorrectly/twice??

Yup, the CQ helpfully landed this patch twice! Since the format is spaced out
and regular it could apply twice successfully. I'll fix and file a bug against
Infra I guess. :(

...
commit 67b831b414b1a10a87d36ae79d6283e4c4f60ac8
Author: scottmg <scottmg@chromium.org>
Date:   Thu Nov 3 11:34:11 2016 -0700

    Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

    Also add component_browsertests to (dbg) config in non-plznav since it
    was missing.

    R=jam@chromium.org

    Review-Url: https://codereview.chromium.org/2468333002
    Cr-Commit-Position: refs/heads/master@{#429655}

commit 8097dff55c84516414ce944ee6bc5435807f4fbc
Author: scottmg <scottmg@chromium.org>
Date:   Thu Nov 3 11:31:23 2016 -0700

    Add components_browsertests and components_unittests runs with
--enable-browser-side-navigation

    Also add component_browsertests to (dbg) config in non-plznav since it
    was missing.

    R=jam@chromium.org

    Review-Url: https://codereview.chromium.org/2468333002
    Cr-Commit-Position: refs/heads/master@{#429654}
...

[ynovikov, 2016-11-03 19:37:23]

On 2016/11/03 19:35:12, scottmg wrote:
> On 2016/11/03 19:29:42, scottmg wrote:
> > On 2016/11/03 19:26:00, ynovikov wrote:
> > > On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > > > Cr-Commit-Position: refs/heads/master@{#429655}
> > > 
> > > This breaks presubmit:
> > > ** Presubmit ERRORS **
> > > manage (0.18s) failed
> > > chromium.linux.json: Linux Tests /
> > > browser_side_navigation_components_browsertests is listed multiple times.
> > > 
> > > Can this be fixed / reverted? Thanks!
> > 
> > I have no idea how that happened, sorry. Looking.
> 
> I think the diff got applied incorrectly/twice??

Yeah, that was my analysis in the second message. Guess revert one of them and
file a bug on commit-bot?

[ynovikov, 2016-11-03 19:38:39]

On 2016/11/03 19:37:13, scottmg wrote:
> On 2016/11/03 19:35:12, scottmg wrote:
> > On 2016/11/03 19:29:42, scottmg wrote:
> > > On 2016/11/03 19:26:00, ynovikov wrote:
> > > > On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > > > > Patchset 1 (id:??) landed as
> > > > > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > > > > Cr-Commit-Position: refs/heads/master@{#429655}
> > > > 
> > > > This breaks presubmit:
> > > > ** Presubmit ERRORS **
> > > > manage (0.18s) failed
> > > > chromium.linux.json: Linux Tests /
> > > > browser_side_navigation_components_browsertests is listed multiple
times.
> > > > 
> > > > Can this be fixed / reverted? Thanks!
> > > 
> > > I have no idea how that happened, sorry. Looking.
> > 
> > I think the diff got applied incorrectly/twice??
> 
> Yup, the CQ helpfully landed this patch twice! Since the format is spaced out
> and regular it could apply twice successfully. I'll fix and file a bug against
> Infra I guess. :(
Thanks! Hope it doesn't apply the revert twice :)
> 
> ...
> commit 67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> Author: scottmg <mailto:scottmg@chromium.org>
> Date:   Thu Nov 3 11:34:11 2016 -0700
> 
>     Add components_browsertests and components_unittests runs with
> --enable-browser-side-navigation
> 
>     Also add component_browsertests to (dbg) config in non-plznav since it
>     was missing.
> 
>     mailto:R=jam@chromium.org
> 
>     Review-Url: https://codereview.chromium.org/2468333002
>     Cr-Commit-Position: refs/heads/master@{#429655}
> 
> commit 8097dff55c84516414ce944ee6bc5435807f4fbc
> Author: scottmg <mailto:scottmg@chromium.org>
> Date:   Thu Nov 3 11:31:23 2016 -0700
> 
>     Add components_browsertests and components_unittests runs with
> --enable-browser-side-navigation
> 
>     Also add component_browsertests to (dbg) config in non-plznav since it
>     was missing.
> 
>     mailto:R=jam@chromium.org
> 
>     Review-Url: https://codereview.chromium.org/2468333002
>     Cr-Commit-Position: refs/heads/master@{#429654}
> ...

[scottmg, 2016-11-03 19:45:20]

On 2016/11/03 19:38:39, ynovikov wrote:
> On 2016/11/03 19:37:13, scottmg wrote:
> > On 2016/11/03 19:35:12, scottmg wrote:
> > > On 2016/11/03 19:29:42, scottmg wrote:
> > > > On 2016/11/03 19:26:00, ynovikov wrote:
> > > > > On 2016/11/03 18:45:34, commit-bot: I haz the power wrote:
> > > > > > Patchset 1 (id:??) landed as
> > > > > > https://crrev.com/67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > > > > > Cr-Commit-Position: refs/heads/master@{#429655}
> > > > > 
> > > > > This breaks presubmit:
> > > > > ** Presubmit ERRORS **
> > > > > manage (0.18s) failed
> > > > > chromium.linux.json: Linux Tests /
> > > > > browser_side_navigation_components_browsertests is listed multiple
> times.
> > > > > 
> > > > > Can this be fixed / reverted? Thanks!
> > > > 
> > > > I have no idea how that happened, sorry. Looking.
> > > 
> > > I think the diff got applied incorrectly/twice??
> > 
> > Yup, the CQ helpfully landed this patch twice! Since the format is spaced
out
> > and regular it could apply twice successfully. I'll fix and file a bug
against
> > Infra I guess. :(
> Thanks! Hope it doesn't apply the revert twice :)

Fix landed here https://codereview.chromium.org/2477803003.

> > 
> > ...
> > commit 67b831b414b1a10a87d36ae79d6283e4c4f60ac8
> > Author: scottmg <mailto:scottmg@chromium.org>
> > Date:   Thu Nov 3 11:34:11 2016 -0700
> > 
> >     Add components_browsertests and components_unittests runs with
> > --enable-browser-side-navigation
> > 
> >     Also add component_browsertests to (dbg) config in non-plznav since it
> >     was missing.
> > 
> >     mailto:R=jam@chromium.org
> > 
> >     Review-Url: https://codereview.chromium.org/2468333002
> >     Cr-Commit-Position: refs/heads/master@{#429655}
> > 
> > commit 8097dff55c84516414ce944ee6bc5435807f4fbc
> > Author: scottmg <mailto:scottmg@chromium.org>
> > Date:   Thu Nov 3 11:31:23 2016 -0700
> > 
> >     Add components_browsertests and components_unittests runs with
> > --enable-browser-side-navigation
> > 
> >     Also add component_browsertests to (dbg) config in non-plznav since it
> >     was missing.
> > 
> >     mailto:R=jam@chromium.org
> > 
> >     Review-Url: https://codereview.chromium.org/2468333002
> >     Cr-Commit-Position: refs/heads/master@{#429654}
> > ...