Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 246833006: Filter out datalist values for textarea field from renderer side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not insert datalist as suggestions for textarea field. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index 95cf8a14a1aff8ea0f06f75969d6685ee4919d12..3450039562f66ffca5216f8344c24e25c19946be 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -88,8 +88,9 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
// If anything else is added to modify the values after inserting the data
// list, AutofillPopupControllerImpl::UpdateDataListValues will need to be
- // updated to match.
- InsertDataListValues(&values, &labels, &icons, &ids);
+ // updated to match. This is for input element only.
+ if (query_field_.form_control_type != "textarea")
+ InsertDataListValues(&values, &labels, &icons, &ids);
Ilya Sherman 2014/04/28 21:23:14 We should filter out datalist values on the render
if (values.empty()) {
// No suggestions, any popup currently showing is obsolete.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698