Filter out datalist values for textarea field from renderer side.

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 70 matching lines @@
   DCHECK_GT(ids.size(), 0U);
   if (ids.back() == POPUP_ITEM_ID_SEPARATOR) {
     values.pop_back();
     labels.pop_back();
     icons.pop_back();
     ids.pop_back();
   }
 
   // If anything else is added to modify the values after inserting the data
   // list, AutofillPopupControllerImpl::UpdateDataListValues will need to be
-  // updated to match.
-  InsertDataListValues(&values, &labels, &icons, &ids);
+  // updated to match. This is for input element only.
+  if (query_field_.form_control_type != "textarea")
+    InsertDataListValues(&values, &labels, &icons, &ids);

[Ilya Sherman, 2014/04/28 21:23:14]

We should filter out datalist values on the renderer side, not on the browser
side.  We should figure out why it's currently possible for the renderer to
associate datalist values with a textarea, and then fix the code so that it's no
longer possible.

 
   if (values.empty()) {
     // No suggestions, any popup currently showing is obsolete.
     manager_->delegate()->HideAutofillPopup();
     return;
   }
 
   // Send to display.
   if (query_field_.is_focusable) {
     manager_->delegate()->ShowAutofillPopup(
@@ skipping 199 matching lines @@
   // Set the values that all datalist elements share.
   icons->insert(icons->begin(),
                 data_list_values_.size(),
                 base::string16());
   unique_ids->insert(unique_ids->begin(),
                      data_list_values_.size(),
                      POPUP_ITEM_ID_DATALIST_ENTRY);
 }
 
 }  // namespace autofill