Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 246833005: Allow hex-style colors to be parsed by fastParseColor in strict mode (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, ojan, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Justin Novosad
Visibility:
Public.

Description

Allow hex-style colors to be parsed by fastParseColor in strict mode Hex-style colors (#rrggbb, #rgb) are valid in strict mode too so allow them to be parsed if |strict| == true. This prevents unnecessarily falling back to the Bison parser in BisonCSSParser::parseColor in these cases. BUG=365560 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
Follow up to the CL (https://codereview.chromium.org/237743009) that made <canvas> .fillStyle/.strokeStyle use "strict" color parsing. Should ...
6 years, 8 months ago (2014-04-22 13:18:02 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-04-22 16:15:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/246833005/1
6 years, 8 months ago (2014-04-22 16:15:53 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 16:22:53 UTC) #4
Message was sent while issue was closed.
Change committed as 172150

Powered by Google App Engine
This is Rietveld 408576698