Don't parse colors for <canvas> in quirks mode

Don't parse colors for <canvas> in quirks mode

Use 'strict' mode when parsing colors, to disallow hex-color
specifications without a leading '#'.

BUG=364008
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171791

[Justin Novosad, 2014-04-16 16:26:49]

lgtm with style nit.

https://codereview.chromium.org/237743009/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasStyle.cpp (right):

https://codereview.chromium.org/237743009/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasStyle.cpp:49: if
(BisonCSSParser::parseColor(parsedColor, colorString, true /* strict */))
The Blinky way of documenting the meaning of 'true' would be to use an enum
instead of a bool. But since this is a pre-existing function, the alternative
would be to declare a constant

const bool useStrictParsing = true;
if (BisonCSSParser::parseColor(parsedColor, colorString, useStrictParsing))

[fs, 2014-04-16 16:34:10]

https://codereview.chromium.org/237743009/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasStyle.cpp (right):

https://codereview.chromium.org/237743009/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasStyle.cpp:49: if
(BisonCSSParser::parseColor(parsedColor, colorString, true /* strict */))
On 2014/04/16 16:26:49, junov wrote:
> The Blinky way of documenting the meaning of 'true' would be to use an enum
> instead of a bool. But since this is a pre-existing function, the alternative
> would be to declare a constant
> 
> const bool useStrictParsing = true;
> if (BisonCSSParser::parseColor(parsedColor, colorString, useStrictParsing))

Ah, yes... I keep forgetting that rule (which think is nice.) Fixed.

[fs, 2014-04-16 16:34:21]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-16 16:34:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/237743009/20001

[commit-bot: I haz the power, 2014-04-16 18:05:45]

Change committed as 171791